Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(visits): add "request imaging button" that auto-populate imaging… #2550

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fibii
Copy link
Contributor

@Fibii Fibii commented Jan 18, 2021

Changes proposed in this pull request:

  • Remove "add visit" button from visits tab (since there's one already) and add a "add imaging request" button instead
  • Implement logic that populates the fields in NewImagingRequest if the user is redirected there from the visits tab

Note: tests are not implemented yet, and some are failing because i removed some stuff without updating the tests, i want a clearance on the changes i made (about the feature), if everything is good, I'll implement the tests!

@vercel
Copy link

vercel bot commented Jan 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/bwf1ja0av
✅ Preview: https://hospitalrun-fr-git-fork-fibii-fibii-feata-new-imaging-re-851042.hospitalrun.vercel.app

@matteovivona matteovivona requested review from jackcmeyer and blestab and removed request for jackcmeyer January 19, 2021 15:02
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jan 19, 2021
const [showAddVisitModal, setShowAddVisitModal] = useState(false)
return (
<>
<div className="row">
<div className="col-md-12 d-flex justify-content-end">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "add visit" button from visits tab (since there's one already) and add a "add imaging request" button instead

Thank @Fibii
kindly note that this was not in the issue specification. This button is needed for UI/UX consistency with the rest of the design.

@blestab
Copy link
Contributor

blestab commented Jan 20, 2021

There should be a new button added to the patient visits page which allows a user to make a new imaging request quickly.

I cannot yet see where this was implemented on the visits page. I am guessing since a new imaging request is done against a patient's visit, I am guessing this would be a button on each visit line item under the Actions column. I'm checking with the UX/UI team on where the button should be placed
cc @lauggh @StefanoMiC @jackcmeyer

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants