Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(ImagingRequest): imaging table requestedBy show current usr #2544

Merged
merged 3 commits into from
Jan 13, 2021

Conversation

riiniii
Copy link
Contributor

@riiniii riiniii commented Jan 8, 2021

requestedBy's current user show's 'test', not actual log in user, pass in logged in user from redux
store to useRequestImaging hook

Fixes #2540.

Changes proposed in this pull request:

  • pass in user information to useRequestImaging hook from NewImagingRequest page by using user information from redux store
  • export interfaces in user-slice to type in tests

Newly added dependencies with Bundlephobia links:

  • no new dependencies

…estedBy show current usr

requestedBy's current user show's 'test', not actual log in user, pass in logged in user from redux
store to useRequestImaging hook

fix HospitalRun#2540
@vercel
Copy link

vercel bot commented Jan 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/6pi5szah1
✅ Preview: https://hospitalrun-frontend-git-fork-riiniii-fix-2540.hospitalrun.vercel.app

…ce.ts): update tests

update tests for NewImagingRequest page and also export relevant interfaces from user-slice.ts

fix HospitalRun#2540
@matteovivona matteovivona requested review from blestab and jackcmeyer and removed request for blestab January 12, 2021 15:53
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jan 12, 2021
@blestab blestab self-requested a review January 12, 2021 16:48
src/imagings/hooks/useRequestImaging.tsx Outdated Show resolved Hide resolved
… user.id but show user.fullName

for requestedBy, save both user.id but also full name, and show  user's fullname in table

fix HospitalRun#2540
Copy link
Contributor

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Imaging Request - requestedBy should store the currently logged in user id
3 participants