Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(ui): forms footer buttons alignment #2519

Merged
merged 9 commits into from
Feb 28, 2021
Merged

fix(ui): forms footer buttons alignment #2519

merged 9 commits into from
Feb 28, 2021

Conversation

Adarsh710
Copy link
Contributor

@Adarsh710 Adarsh710 commented Dec 15, 2020 •
edited
Loading

Fix #2518

Changes proposed in this pull request:

  • Added class mr-3 to all button groups
  • Removed class mr-2 from Resolve button in ViewIncidentDetails component for better alignment
  • Added class mt-3 in buttons group container of EditPatient component.

Total files changed : 11

@gitpod-io
Copy link

gitpod-io bot commented Dec 15, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Dec 15, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/EQ49fqvFtrVLrEEqyGNZ9FevsX7q
✅ Preview: https://hospitalrun-frontend-git-fork-adarsh710-master-hospitalrun.vercel.app

@blestab blestab changed the title fix: fixed buttons alignment by giving right margin (#1) fix(ui): fixed forms footer buttons alignment by giving right margin Dec 15, 2020
@blestab blestab requested review from blestab and jackcmeyer and removed request for blestab December 15, 2020 16:51
blestab
blestab suggested changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Adarsh710, looking good on the new forms as well as some edit forms.

May you also fix these edit forms:

  • Patient Edit
    image

  • Appointment Edit
    image

@Adarsh710
Copy link
Contributor Author

Thank you @Adarsh710, looking good on the new forms as well as some edit forms.

May you also fix these edit forms:

  • Patient Edit
    image
  • Appointment Edit
    image

Nice catch, fixing these too

blestab
blestab approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@blestab blestab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blestab blestab changed the title fix(ui): fixed forms footer buttons alignment by giving right margin fix(ui): forms footer buttons alignment by giving right margin Dec 15, 2020
@blestab blestab changed the title fix(ui): forms footer buttons alignment by giving right margin fix(ui): forms footer buttons alignment Dec 15, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Dec 16, 2020
@matteovivona matteovivona added this to In progress in Version 2.0 via automation Dec 16, 2020
@matteovivona matteovivona added this to the v2.0 milestone Dec 16, 2020
@CLAassistant
Copy link

CLAassistant commented Jan 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@matteovivona matteovivona merged commit 123c653 into HospitalRun:master Feb 28, 2021
Version 2.0 automation moved this from In progress to Done Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blestab blestab blestab approved these changes

@jackcmeyer jackcmeyer Awaiting requested review from jackcmeyer

Assignees
No one assigned
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

UI: Forms footer buttons alignment
4 participants
@Adarsh710 @CLAassistant @blestab @matteovivona