Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

refactor(patients): Improve date format consistency #2447

Merged
merged 3 commits into from
Oct 28, 2020
Merged

refactor(patients): Improve date format consistency #2447

merged 3 commits into from
Oct 28, 2020

Conversation

boredcity
Copy link
Contributor

@boredcity boredcity commented Oct 25, 2020 •
edited by blestab
Loading

Fixes #2439

Changes proposed in this pull request:

  • add formatDate helpers
  • add tests for formatDate helper
  • use formatDate in components, mentioned in the issue (ViewPatientsTable, ImportantPatientInfo)

image

Newly added dependencies with Bundlephobia links:

  • no new dependencies

@jsf-clabot
Copy link

jsf-clabot commented Oct 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 25, 2020

Someone is attempting to deploy a commit to the HospitalRun Team on Vercel.

A member of the Team first needs to authorize it.

@boredcity boredcity changed the title fix(format-consistency): date format consistency improved Improve date format consistency Oct 25, 2020
@blestab blestab changed the title Improve date format consistency refactor(patients): Improve date format consistency Oct 25, 2020
@blestab blestab added hacktoberfest-accepted patients issue/pull request that interacts with patients module 🚀enhancement an issue/pull request that adds a feature to the application labels Oct 25, 2020
@blestab blestab added this to In progress in Version 2.0 via automation Oct 25, 2020
@blestab blestab added this to the v2.0 milestone Oct 25, 2020
@blestab
Copy link
Contributor

blestab commented Oct 25, 2020

Thank you @merelj

Thank you for your contribution; may go ahead and sign the CLA.

@boredcity
Copy link
Contributor Author

@blestab

may go ahead and sign the CLA

sure thing 👌
licence/cla check failed and suggested me to add another email to my profile which I did. But it seems to be stuck now 😕

@jackcmeyer
Copy link
Member

@blestab

may go ahead and sign the CLA

sure thing 👌
licence/cla check failed and suggested me to add another email to my profile which I did. But it seems to be stuck now 😕

Could you close the PR and reopen it again? That usually fixes the bot.

@matteovivona matteovivona removed their request for review October 25, 2020 20:39
@vercel
Copy link

vercel bot commented Oct 25, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/i0d2h9cbq
✅ Preview: https://hospitalrun-frontend-git-universal-format-for-dates.hospitalrun.vercel.app

@boredcity
Copy link
Contributor Author

Could you close the PR and reopen it again? That usually fixes the bot.

ok, it suddenly just worked 🎉 😄

@jackcmeyer jackcmeyer merged commit ebc916c into HospitalRun:master Oct 28, 2020
Version 2.0 automation moved this from In progress to Done Oct 28, 2020
ho1234c pushed a commit to ho1234c/hospitalrun-frontend that referenced this pull request Oct 28, 2020
@boredcity @matteovivona @ho1234c
refactor(patients): Improve date format consistency (HospitalRun#2447)
4610ea8 
Co-authored-by: Matteo Vivona <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blestab blestab blestab approved these changes

@jackcmeyer jackcmeyer jackcmeyer approved these changes

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application hacktoberfest-accepted patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Patient View: Date fields display format consistency
5 participants
@boredcity @jsf-clabot @blestab @jackcmeyer @matteovivona