Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(patients): patient view buttons hover style inconsistency #2446

Merged
merged 4 commits into from
Dec 9, 2020
Merged

fix(patients): patient view buttons hover style inconsistency #2446

merged 4 commits into from
Dec 9, 2020

Conversation

kud04rk
Copy link
Contributor

@kud04rk kud04rk commented Oct 25, 2020 •
edited by blestab
Loading

Fixes #2441 Patient View: Buttons hover style inconsistency

Changes proposed in this pull request:

  1. changed the colors to match the add allergy button

I have run the test for the modified code and
test results.txt.

Please review and let me know if i have made any mistake.

Newly added dependencies with Bundlephobia links:

NONE

@jsf-clabot
Copy link

jsf-clabot commented Oct 25, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Oct 25, 2020 •
edited
Loading

@vercel
Copy link

vercel bot commented Oct 25, 2020

@smsriharsha is attempting to deploy a commit to the HospitalRun Team on Vercel.

A member of the Team first needs to authorize it.

@blestab blestab added hacktoberfest-accepted patients issue/pull request that interacts with patients module 🐛bug issue/pull request that documents/fixes a bug labels Oct 25, 2020
@blestab blestab added this to In progress in Version 2.0 via automation Oct 25, 2020
@blestab blestab changed the title updated styles to match the add allergy button fix(patients): patient view buttons hover style inconsistency Oct 25, 2020
@blestab
Copy link
Contributor

blestab commented Oct 25, 2020 •
edited
Loading

Hi @smsriharsha
Thank you for your contribution.

  1. May you go ahead and sign the CLA
  2. May you also fix the lint errors in src/patients/view/ImportantPatientInfo.tsx by doing the following:
    • run npm run lint to confirm if there are any lint errors
    • then run npm rum lint:fix to fix the lint errors , if any and commit the changes

@jackcmeyer jackcmeyer self-requested a review October 25, 2020 19:53
@vercel
Copy link

vercel bot commented Oct 25, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/kfclfq684
✅ Preview: https://hospitalrun-frontend-git-master.hospitalrun.now.sh

@matteovivona matteovivona removed their request for review October 25, 2020 20:38
blestab
blestab suggested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May you fix the lint errors:

npm run lint:fix and then commit the changes

@blestab
Copy link
Contributor

blestab commented Dec 6, 2020

Hi @jackcmeyer i believe this one is all set. Merge and lint issues were resolved.

@jackcmeyer jackcmeyer merged commit 081488b into HospitalRun:master Dec 9, 2020
Version 2.0 automation moved this from In progress to Done Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blestab blestab blestab approved these changes

@jackcmeyer jackcmeyer jackcmeyer approved these changes

Assignees
No one assigned
Labels
🐛bug issue/pull request that documents/fixes a bug hacktoberfest-accepted patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient View: Buttons hover style inconsistency
5 participants
@kud04rk @jsf-clabot @blestab @jackcmeyer @matteovivona