Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

fix(care plan): fix view button label in list #2376

Merged
merged 2 commits into from
Sep 9, 2020

Conversation

gaweki
Copy link
Contributor

@gaweki gaweki commented Sep 8, 2020

Fixes #2372

Changes proposed in this pull request:

  • add t() function invoking on key actions.view(available for enUS translations)

Newly added dependencies with Bundlephobia links:

NONE

@jsf-clabot
Copy link

jsf-clabot commented Sep 8, 2020

CLA assistant check
All committers have signed the CLA.

@gitpod-io
Copy link

gitpod-io bot commented Sep 8, 2020

@gaweki gaweki changed the title fix: Fix label View in Care Plans List fix(care plan): Fix label View in Care Plans List Sep 9, 2020
@jackcmeyer
Copy link
Member

@gaweki looks like the build is failing. Also, you'll need to sign the CLA.

@gaweki
Copy link
Contributor Author

gaweki commented Sep 9, 2020

how to sign the CLA, mr @jackcmeyer ? and how to fix the build?

@jackcmeyer
Copy link
Member

jackcmeyer commented Sep 9, 2020

@gaweki

To sign CLA: click the hyperlinks in the comment: #2376 (comment).

To fix build, run npm run lint locally and fix the errors that appear. Some of them may be autofixable with npm run lint:fix

@jackcmeyer jackcmeyer added the 🐛bug issue/pull request that documents/fixes a bug label Sep 9, 2020
@jackcmeyer jackcmeyer added this to In progress in Version 2.0 via automation Sep 9, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Sep 9, 2020
@@ -4,6 +4,7 @@ export default {
filterTitle: 'Filter by status',
search: 'Search labs',
successfullyUpdated: 'Successfully updated',
successfullyCompleted: 'Succesfully Completed',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @jackcmeyer wanted this to be Successfully completed ${type} for ${patient}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i add 'for' text? Cause the original text must be ${t('labs.successfullyCompleted')} ${complete.type} ${patient?.fullName} @morrme @jackcmeyer

Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep Pull Requests as atomic units, I think we should move the fixing of the lab success message to a different pull request.

@gaweki
Copy link
Contributor Author

gaweki commented Sep 9, 2020

To keep Pull Requests as atomic units, I think we should move the fixing of the lab success message to a different pull request.

i make PR from different branch and start from latest commit on master branch original repo?

@gaweki
Copy link
Contributor Author

gaweki commented Sep 9, 2020

To keep Pull Requests as atomic units, I think we should move the fixing of the lab success message to a different pull request.

already reset commits. another commit is on another PR @jackcmeyer

@vercel vercel bot temporarily deployed to Preview September 9, 2020 13:05 Inactive
@vercel
Copy link

vercel bot commented Sep 9, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/2v11mvzov
✅ Preview: https://hospitalrun-frontend-git-fork-gaweki-master.hospitalrun.vercel.app

@jackcmeyer jackcmeyer changed the title fix(care plan): Fix label View in Care Plans List fix(care plan): fix view button label in list Sep 9, 2020
@jackcmeyer jackcmeyer merged commit 6156f38 into HospitalRun:master Sep 9, 2020
Version 2.0 automation moved this from In progress to Done Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug
Projects
Version 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Care Plan list view action button shows translation key instead of translation text
6 participants