This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
refactor(imaging): use react query instead of redux to fetch imaging data #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackcmeyer
added
🚀enhancement
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/bw16im2un |
jackcmeyer
force-pushed
the
imaging-react-query
branch
from
d8785ad
to
2baa7f7
Compare
blestab
reviewed
Sep 1, 2020
| import Imaging from '../../../shared/model/Imaging' | ||
|
|
||
| describe('imaging request validator', () => { | ||
| it('should validate the required fields apart of an incident', async () => { |
There was a problem hiding this comment.
Not a train smash, but may we fix test description, "are part of an incident" instead of "apart of an incident"?
blestab
reviewed
Sep 1, 2020
|
|
||
| await ImagingRepository.save({ | ||
| ...request, | ||
| requestedBy: 'test', |
There was a problem hiding this comment.
Is this not meant to be the actual user?
blestab
approved these changes
Sep 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2340
Changes proposed in this pull request:
useImagingRequest,useImagingSearch, anduseRequestImaging