test(login): improve test login screen

[rsousaj]

Fixes #2278

• Added unit tests for Login Screen

[jsf-clabot]

All committers have signed the CLA.

[gitpod-io]

[rsousaj]

Hi guys, sorry about the import's mess. It's my first contribution.
So, I tried to cancel the PR but I couldn't.

How can I procedure now ?

Thanks

[morrme]

Hi guys, sorry about the import's mess. It's my first contribution.
So, I tried to cancel the PR but I couldn't.

How can I procedure now ?

Thanks

@rsousaj
Welcome and thank you for your contribution!

Are you able to edit the file from your branch?

If so you can continue to make changes and then git commit and git push again. This PR will automatically reflect any additional change you make.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/j02dclron
✅ Preview: https://hospitalrun-frontend-git-fork-rsousaj-logintest.hospitalrun.vercel.app

[rsousaj]

Hi guys, sorry about the import's mess. It's my first contribution.
So, I tried to cancel the PR but I couldn't.
How can I procedure now ?
Thanks

@rsousaj
Welcome and thank you for your contribution!

Are you able to edit the file from your branch?

If so you can continue to make changes and then git commit and git push again. This PR will automatically reflect any additional change you make.

Oh, that's awesome! I'll clean up my mess

[rsousaj]

I've tried to refactor the imports but look like I'm still messing around. The organized import is not being recognized as a change when I try to commit on git. I'm so sorry guys.

Maybe would be better if the PR being rejected and I try starting all over again

[morrme]

I've tried to refactor the imports but look like I'm still messing around. The organized import is not being recognized as a change when I try to commit on git. I'm so sorry guys.

Maybe would be better if the PR being rejected and I try starting all over again

Can you tell us what you're trying to accomplish, or send a screenshot of the changes as they appear for you locally?

Have you tried "staging" your changes (via git add) before committing?

[rsousaj]

I've tried to refactor the imports but look like I'm still messing around. The organized import is not being recognized as a change when I try to commit on git. I'm so sorry guys.
Maybe would be better if the PR being rejected and I try starting all over again

Can you tell us what you're trying to accomplish, or send a screenshot of the changes as they appear for you locally?

Have you tried "staging" your changes (via git add) before committing?

Oh, thank you so much. Really appreciate! Down below the screenshot after staging changes.

But after commit, it fails on "no-empty-commit" rule. Before, I need to admit that, I tried to cheat and also changed the Test Suite name but couldn't commit the right code.

[morrme]

@rsousaj Are you referring to the import order? This might be something that is changing based on the project standards.
It looks like your code has passed all of the checks, including those for import order, so you may be ok 👍🏾

[rsousaj]

@rsousaj Are you referring to the import order? This might be something that is changing based on the project standards.
It looks like your code has passed all of the checks, including those for import order, so you may be ok 👍🏾

Yes, I was. Once more, tks a lot. Really happy to contribute.

[morrme]

Yes, I was. Once more, tks a lot. Really happy to contribute.

We are happy to have you ! Feel free to join us in the Slack group as well: https://hospitalrun-slack.herokuapp.com/

[morrme]

@jackcmeyer Do you mind reviewing this one?