Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Conversation

Tomastomaslol
Copy link
Contributor

Fixes #2260.

Changes proposed in this pull request:

  • Added new action resetLab in lab-slice.ts
  • Invoke resetLab when newLabReuqest is rendered

No new dependencies added dependencies

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tomas Nygren seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@gitpod-io
Copy link

gitpod-io bot commented Jul 31, 2020

@Tomastomaslol Tomastomaslol force-pushed the 2260_previous_errors_are_showing_up_in_lab_request_screen branch from a46a874 to 2ce6b8e Compare July 31, 2020 04:56
@matteovivona
Copy link
Contributor

Hi @Tomastomaslol, can you sign our CLA before we can accept your PR? Thanks!

@vercel
Copy link

vercel bot commented Jul 31, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/estt27xis
✅ Preview: https://hospitalrun-fr-git-fork-tomastomaslol-2260previouserrors-01b783.hospitalrun.vercel.app

@matteovivona matteovivona added this to In progress in Version 2.0 via automation Jul 31, 2020
@matteovivona matteovivona added this to the v2.0 milestone Jul 31, 2020
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jul 31, 2020
@Tomastomaslol
Copy link
Contributor Author

Hi @tehkapa and thanks for looking at my pull request. I normally don't use GitHub so I had to amend my commit to match my Github account after accepting the CLA. I'm not sure if that made the label confused. However, it looks like CLA check has passed in the list of checks. Should this be sufficient?

Otherwise, I can try to reopen the pull request.

@matteovivona
Copy link
Contributor

That might be enough for me. @fox1t?

@jackcmeyer
Copy link
Member

@Tomastomaslol I think we try and reopen the PR. I can see all the commits are associated with our account, so I think the bot may be confused.

Version 2.0 automation moved this from In progress to Done Aug 2, 2020
@Tomastomaslol
Copy link
Contributor Author

Reopened: #2268

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on
Projects
Version 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Previous errors are showing up in lab request screen
4 participants