Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

WIP: feat(sidebar): strip sidebar collapse functionality to user level #2174

Closed
wants to merge 3 commits into from

Conversation

elveskevtar
Copy link

@elveskevtar elveskevtar commented Jun 25, 2020

Signed-off-by: Kevin Tarta [email protected]
Adds feature #2098.

Changes proposed in this pull request:

  • Strip out sidebar collapsing and place functionality in user-slice
  • Enable changing the metadata for auth user in couchdb (new sidebar field)
  • Enable fetching the new metadata when loading the sidebar (this adds persistence of the state across sessions/devices/etc)

Newly added dependencies with Bundlephobia links:

N/A

@jsf-clabot
Copy link

jsf-clabot commented Jun 25, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hospitalrunbot
❌ Kevin Tarta


Kevin Tarta seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@gitpod-io
Copy link

gitpod-io bot commented Jun 25, 2020

@vercel
Copy link

vercel bot commented Jun 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/1e3f02z44
✅ Preview: https://hospitalrun-frontend-git-fork-elveskevtar-savesidebar.hospitalrun.vercel.app

@matteovivona matteovivona requested review from jackcmeyer, fox1t and a user June 25, 2020 07:40
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Jun 25, 2020
@matteovivona matteovivona added this to the v2.0 milestone Jun 25, 2020
@vercel vercel bot temporarily deployed to Preview June 26, 2020 13:07 Inactive
@matteovivona
Copy link
Contributor

Hi @elveskevtar, can you sign our CLA and resolve conflicts? Thanks

@fox1t
Copy link
Member

fox1t commented Jul 10, 2020

LGTM, after resolution and sign. :)

@matteovivona
Copy link
Contributor

@elveskevtar can you sign CLA and resolve conflicts? Really appreciated!

@matteovivona matteovivona self-assigned this Jul 24, 2020
@matteovivona matteovivona self-requested a review July 30, 2020 13:13
@matteovivona matteovivona added the 🚀enhancement an issue/pull request that adds a feature to the application label Jul 30, 2020
@matteovivona matteovivona changed the title feat(sidebar): strip sidebar collapse functionality to user level WIP: feat(sidebar): strip sidebar collapse functionality to user level Aug 17, 2020
@matteovivona matteovivona requested review from morrme and removed request for a user and jackcmeyer August 20, 2020 09:18
@matteovivona matteovivona assigned morrme and unassigned matteovivona Aug 20, 2020
@morrme
Copy link
Contributor

morrme commented Aug 20, 2020

@tehkapa So this looks good on its own but some of this may conlflict with @jackcmeyer 's hooks migration. I don't have access to view/resolve conflicts but I suspect that may be what's going on.

@matteovivona
Copy link
Contributor

@tehkapa So this looks good on its own but some of this may conlflict with @jackcmeyer 's hooks migration. I don't have access to view/resolve conflicts but I suspect that may be what's going on.

you'd better create a new branch from this brach, merge the master in the new branch and see if you can manage conflicts

@fox1t
Copy link
Member

fox1t commented Sep 7, 2020

Is this PR stale?

@jackcmeyer jackcmeyer closed this Sep 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants