refactor: changed const name and removed css class

[maciekglowacki]

There is const hambergerPages in Navbar.tsx file used to map pagesMap object to its values.With annotation that it should display hamburger menu on mobile devices.

However on mobile device a dropdown menu is shown instead of hamburger menu.

I would rename the const simply to pages.

There is a css class "nav-hamburger" but it does not change any styling of nav item.

That is my first pull request so if I should do some changes, please instruct me how to make them :).

[jsf-clabot]

All committers have signed the CLA.

[gitpod-io]

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/4x12ir1mw
✅ Preview: https://hospitalrun-frontend-git-fork-maciekglowacki-hamburger.hospitalrun.vercel.app

[matteovivona]

Hi @maciekglowacki, thank you for your submission! What's issue fix (would you link it in PR description Fixes #xxx )?
Another thing: we ask that you all sign our CLA before we can accept your contribution.

[maciekglowacki]

Hi @tehkapa. I signed CLA. I didn't know how to properly create an issue. Should I always create an issue before making a PR?

[matteovivona]

Hi @tehkapa. I signed CLA. I didn't know how to properly create an issue. Should I always create an issue before making a PR?

Does your PR start with any existing issues? Also, there are some failing with tests (to be solved)

[maciekglowacki]

Does your PR start with any existing issues? Also, there are some failing with tests (to be solved)

No, it doesn't. I will have a look at the tests.

[ghost]

Good eye for catching this inaccurate naming 🙂 It is planned to have a hamberger icon when available (please see HospitalRun/components#456).

[ghost]

Please checkout the current master for check-translations/index.ts so there will be no changes in this file.

[vercel]

Deployment failed with the following error:

Resource is limited - try again after in 6 minutes (more than 32, code: "api-deployments-free-builds-per-hour").

[vercel]

Deployment failed with the following error:

Resource is limited - try again after in 1 hour (more than 100, code: "api-deployments-free-per-day").

[vercel]

Deployment failed with the following error:

Resource is limited - try again after in 6 hours (more than 100, code: "api-deployments-free-per-day").

[vercel]

Deployment failed with the following error:

Resource is limited - try again after in 4 hours (more than 100, code: "api-deployments-free-per-day").

[ghost]

@maciekglowacki Hi, there's an update about the mobile dropdown menu! The hamberger icon has been added in the Components repo, and this PR is work-in-progress to apply it to the mobile navigation bar. May we ask you to review that PR and let us know what you think?

[lgtm-com]

This pull request introduces 1 alert when merging afb9657 into 99c2e16 - view on LGTM.com

new alerts:

• 1 for Unused variable, import, function or class

[ghost]

@maciekglowacki Hi, there's an update about the mobile dropdown menu! The hamberger icon has been added in the Components repo, and this PR is work-in-progress to apply it to the mobile navigation bar. May we ask you to review that PR and let us know what you think?

Further update. The above mentioned PR has been merged with master.