Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(i18n): add new script for checking missing translations #2034

Merged
merged 56 commits into from
Jun 10, 2020
Merged

feat(i18n): add new script for checking missing translations #2034

merged 56 commits into from
Jun 10, 2020

Conversation

marcosvega91
Copy link
Contributor

@marcosvega91 marcosvega91 commented May 2, 2020

Fixes #1919

Changes proposed in this pull request:

  • I added new dep for running typscript script(ts-node)
  • I updated the linter path for checking the new
    folder scripts
  • I added a new command yarn translation:check to check if some translations are
    missing

When you run the command It will print some information of the library i18next because the debug is active

Newly added dependencies with Bundlephobia links:

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Provide tests for all code that you add/modify. If you add/modify any components update the storybook. Thanks! (you can delete this text)

I add new dep for running typscript script(ts-node). I update the linter path for checking the new
folder scripts. With the command yarn translation:check you can check if some translations are
missing. All erros will print in the console

fix #1919
@vercel
Copy link

vercel bot commented May 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/4fmg5n0wn
✅ Preview: https://hospitalrun-fro-git-fork-marcosvega91-feature-checktrans-7ec5f4.hospitalrun.now.sh

@gitpod-io
Copy link

gitpod-io bot commented May 2, 2020

@matteovivona matteovivona requested a review from fox1t May 2, 2020 12:13
@matteovivona matteovivona changed the title feat(add new script for checking missing translations): translations feat(i18n): add new script for checking missing translations May 2, 2020
@matteovivona matteovivona added devops issue/pull request that includes changes to documentation to devops processes localization and removed devops issue/pull request that includes changes to documentation to devops processes labels May 2, 2020
@vercel vercel bot temporarily deployed to Preview May 2, 2020 12:58 Inactive
@vercel vercel bot temporarily deployed to Preview May 2, 2020 13:09 Inactive
@marcosvega91
Copy link
Contributor Author

marcosvega91 commented May 2, 2020

I didn't understend why webstorm created a file json in the root 🤮. I deleted it

Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super awesome stuff!

package.json Outdated Show resolved Hide resolved
scripts/checkMissingTranslations.ts Outdated Show resolved Hide resolved
scripts/checkMissingTranslations.ts Outdated Show resolved Hide resolved
scripts/checkMissingTranslations.ts Outdated Show resolved Hide resolved
@jackcmeyer jackcmeyer added this to In progress in Version 2.0 via automation May 2, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone May 2, 2020
now ts-node library is no need anymore because the script is compiled to javascript
…hospitalrun-frontend into feature/check_translations
fox1t
fox1t previously approved these changes Jun 8, 2020
@fox1t
Copy link
Member

fox1t commented Jun 8, 2020

Awesome!
LGTM

@marcosvega91
Copy link
Contributor Author

I see that something was wrong with build. I fixed that

@matteovivona matteovivona merged commit c7f39c1 into HospitalRun:master Jun 10, 2020
Version 2.0 automation moved this from In progress to Done Jun 10, 2020
@marcosvega91 marcosvega91 deleted the feature/check_translations branch June 10, 2020 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on localization
Projects
Version 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Warn about missing translations
4 participants