Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(patient): add appointment button #1964

Merged
merged 27 commits into from
Apr 16, 2020
Merged

Conversation

oizuldan
Copy link
Contributor

@oizuldan oizuldan commented Apr 4, 2020

Fixes #1841.

Changes proposed in this pull request:

  • Add "Add Appointment" button on the patient page, appointments tab.

@vercel
Copy link

vercel bot commented Apr 4, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/166kr9orz
✅ Preview: https://hospitalrun-frontend-git-fork-oizuldan-master.hospitalrun.now.sh

src/patients/appointments/AppointmentsList.tsx Outdated Show resolved Hide resolved
src/patients/appointments/AppointmentsList.tsx Outdated Show resolved Hide resolved
@oizuldan
Copy link
Contributor Author

oizuldan commented Apr 7, 2020

@jackcmeyer I have added tests and everything seems to work fine

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Apr 8, 2020
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to check some tests that are not passing.

@oizuldan
Copy link
Contributor Author

Hey @oizuldan, let me know if you need any help getting this pull request finished up!

Okay!

@oizuldan
Copy link
Contributor Author

A stylistic change:

Can we make the New Appointment aligned with all of the other "Add" buttons in the diagnoses tab, allergies tab, etc.

Will do

@jackcmeyer
Copy link
Member

@oizuldan code changes look good. just need to fix linter errors. let me know if you need any help!

jackcmeyer
jackcmeyer previously approved these changes Apr 14, 2020
@jackcmeyer jackcmeyer added patients issue/pull request that interacts with patients module 🚀enhancement an issue/pull request that adds a feature to the application labels Apr 14, 2020
@jackcmeyer jackcmeyer added this to In progress in Version 2.0 via automation Apr 14, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Apr 14, 2020
@oizuldan
Copy link
Contributor Author

@oizuldan code changes look good. just need to fix linter errors. let me know if you need any help!

Do I need to fix these errors? (I am a little confused since you already approved my PR)

@vercel vercel bot requested a deployment to Preview April 16, 2020 15:08 Abandoned
@vercel
Copy link

vercel bot commented Apr 16, 2020

Deployment failed with the following error:

request to https://api.zeit.co/v12/now/deployments?teamId=team_KiGwX2JSRgAI3krc36DK1uGg&skipAutoDetectionConfirmation=1 failed, reason: socket hang up

@matteovivona matteovivona self-requested a review April 16, 2020 17:46
@matteovivona matteovivona merged commit 5d02d97 into HospitalRun:master Apr 16, 2020
Version 2.0 automation moved this from In progress to Done Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
Version 2.0
  
Done
Development

Successfully merging this pull request may close these issues.

Add new appointment button in patient's appointments tab
4 participants