Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

WIP: feat(scheduling): adding error feedback for new & edit appointment #1949

Closed
wants to merge 66 commits into from
Closed

WIP: feat(scheduling): adding error feedback for new & edit appointment #1949

wants to merge 66 commits into from

Conversation

patrick-salvatore
Copy link

@patrick-salvatore patrick-salvatore commented Mar 28, 2020 •
edited by gitpod-io bot
Loading

Fixes #1917.

Changes proposed in this pull request:

  • Added error feedback on the new & edit appointment forms

@patrick-salvatore
feat('scheduling: new & edit appointment'): addded error feedback #1917
494b84b 
'Added error feedback on the new & edit appointment forms'

'#1917'
@jsf-clabot
Copy link

jsf-clabot commented Mar 28, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel
Copy link

vercel bot commented Mar 28, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/cbvpodmnd
✅ Preview: https://hospitalrun-front-git-fork-patrick-salvatore-feedback-ms-782a13.hospitalrun.now.sh

@patrick-salvatore patrick-salvatore changed the title feat('scheduling: new & edit appointment'): addded error feedback #1917 feat('scheduling: new & edit appointment'): adding error feedback #1917 Mar 28, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 28, 2020

This pull request introduces 1 alert when merging 494b84b into 19768a1 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2020

This pull request introduces 1 alert when merging c7d9613 into d6904e7 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2020

This pull request introduces 1 alert when merging 9aa89f8 into e17dd1d - view on LGTM.com

new alerts:

  • 1 for Identical operands

@patrick-salvatore patrick-salvatore changed the title feat('scheduling: new & edit appointment'): adding error feedback #1917 feat(scheduling): adding error feedback for new & edit appointment Mar 29, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2020

This pull request introduces 1 alert when merging e1b6494 into 4e14abf - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2020

This pull request introduces 1 alert when merging 59b6e5b into ec7746c - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Mar 30, 2020

This pull request introduces 1 alert when merging 367b231 into ce3357e - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging 1c2b21f into a643274 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging 30d38ce into b2b7990 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@lgtm-com
Copy link

lgtm-com bot commented May 3, 2020

This pull request introduces 1 alert when merging 6c11a6d into b695ac8 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@vercel vercel bot temporarily deployed to Preview May 4, 2020 08:18 Inactive
@gitpod-io
Copy link

gitpod-io bot commented May 4, 2020

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2020

@lgtm-com
Copy link

lgtm-com bot commented May 4, 2020

This pull request introduces 1 alert when merging 6e03fe1 into c086dc1 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2020

@gitpod-io
Copy link

gitpod-io bot commented May 4, 2020

@gitpod-io
Copy link

gitpod-io bot commented May 5, 2020

@vercel vercel bot temporarily deployed to Preview May 5, 2020 15:24 Inactive
@gitpod-io
Copy link

gitpod-io bot commented May 5, 2020

@gitpod-io
Copy link

gitpod-io bot commented May 5, 2020

@lgtm-com
Copy link

lgtm-com bot commented May 5, 2020

This pull request introduces 1 alert when merging 2fb9b98 into b795bf8 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@gitpod-io
Copy link

gitpod-io bot commented May 6, 2020

@lgtm-com
Copy link

lgtm-com bot commented May 6, 2020

This pull request introduces 1 alert when merging 94e6be9 into e208ca6 - view on LGTM.com

new alerts:

  • 1 for Identical operands

@jackcmeyer jackcmeyer closed this May 11, 2020
Version 2.0 automation moved this from In progress to Done May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fox1t fox1t fox1t left review comments

@jackcmeyer jackcmeyer jackcmeyer requested changes

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on scheduling issue/pull request that interacts with scheduling module
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Provide better feedback in New Appointment/Edit Appointment Form
5 participants
@patrick-salvatore @jsf-clabot @fox1t @jackcmeyer @matteovivona