Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(view patient): add 'edit' icon to Edit button #1826

Merged
merged 8 commits into from
Feb 19, 2020

Conversation

MatthewDorner
Copy link
Contributor

Fixes #1765

  • Add 'edit' pencil icon to "Edit" button on View Patient component.

@vercel
Copy link

vercel bot commented Feb 16, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/4uqes0dz3
✅ Preview: https://hospitalrun-frontend-git-fork-matthewdorner-add-pencil-icon.hospitalrun.now.sh

Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@MatthewDorner
Copy link
Contributor Author

MatthewDorner commented Feb 16, 2020

These test failures are confusing to me. One is failing due to 'document update conflict' and another one is failing because the storybook (?) part of the test script failed. But I don't even see storybook in the other test runs that passed. Have we still been having test problems? I just looked at GitHub actions on master branch and it looks like most are passing...

edit: haha I guess they are all failing, must not have looked at it since yesterday... I will try to look into this

@vercel vercel bot temporarily deployed to Preview February 18, 2020 08:16 Inactive
@matteovivona
Copy link
Contributor

@MatthewDorner storybook check fails due to my error. I corrected github action conf file this morning

@MatthewDorner
Copy link
Contributor Author

Yeah, I guessed the storybook thing was just added by mistake. Otherwise it looks like it's failing on Windows and the failure (on this and pretty much all the CI runs) is related to the tests that use PouchDB. Though I have seen those "document update conflict" errors a few times on my Linux environment, lately everything's been passing for me locally.

@matteovivona
Copy link
Contributor

@HospitalRun/core-maintainers any of you guys got windows?

@matteovivona matteovivona added in progress indicates that issue/pull request is currently being worked on v2.x labels Feb 18, 2020
@MatthewDorner
Copy link
Contributor Author

I can play around with it on a VM when I get some time. It's not just this PR, though, seems to have started failing this way on all the CI runs a few days ago...

@jackcmeyer
Copy link
Member

@tehkapa I have a windows machine and I am unable to reproduce.

@vercel vercel bot requested a deployment to Preview February 19, 2020 06:53 Abandoned
@vercel
Copy link

vercel bot commented Feb 19, 2020

You are pushing commits at a very fast pace (across the whole organization).
Due to that, we cannot deploy the commit e786c74.

You can try again later or upgrade your plan.

@matteovivona matteovivona merged commit f603175 into HospitalRun:master Feb 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in progress indicates that issue/pull request is currently being worked on v2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit patient details
3 participants