Ember2.x tests #178
Ember2.x tests #178
Conversation
|
I thought we werent going to use mirage? |
|
We didn't end up using it. I'm still using it to install Pretender which is used to mock authentication requests. We can remove it if there is preference to not have it in and just install Pretender manually. |
|
@taras if we aren't using mirage, can you remove it from this PR? |
|
It's providing Pretender, I'll remove it and install Pretender another way |
|
@jkleinsc I just pushed a commit that replaces |
|
|
||
| database: Ember.inject.service(), | ||
| mainDB: Ember.computed.alias('database.mainDB'), | ||
| db: Ember.computed.alias('database.mainDB'), |
There was a problem hiding this comment.
can we merge mainDB and db into one since they point to the same thing.
There was a problem hiding this comment.
We have another PR in the works that removes mainDB because it's not being used in this adapter.
|
I am working on refactoring the config db/service to remove the config adapter and not use ember data for the config data. Eventually the config db will be replaced |
| 'simple-auth': { | ||
|
|
||
| }, | ||
| 'ember-cli-mirage': { |
|
In the future can we merge whitespace changes into a separate commit? makes it easier to read :) |
|
@billybonks I'm with you but I think it might be done by the editor which is removing the whitespaces. I'll do my best for the future :) |
|
@taras and @billybonks I think I would like to cleanup all of the whitespace/indent spacing on the files for consistency and am thinking of adding ember suave to enforce/cleanup formatting. It's my bad for not having an explicit style guide, but I think it makes sense to use the defaults from ember suave. |
|
@jkleinsc +1 on using ember-suave |
|
@jkleinsc we probably should have squashed those commits. Agree? |
|
@taras what commits? |
|
The 21 commits that we just merged. I'm just saying that for the sake of keeping history clean, we could squash the commits before merging into master. |
|
Yes... I'm not sure if that just happened because I did a manual merge. |
|
👍 to squashing, @taras ye its the editor mine does the same, i just stage the white space hunks and commit them with fix up. @jkleinsc ember-suave is good defaults, i'm not sure what editor you use, but if you want to fix whitespace sublime and atom, automatically fix it if you open it and save, so you could go open everything save commit 😄. @taras thanks for this. |
loadPouchDumphelper