This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Bind attr #177
Merged
Bind attr #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billybonks
force-pushed
the
bind-attr
branch
from
fe3b99e
to
bc3fe64
Compare
-bind-attr -removed deprecated scope
billybonks
force-pushed
the
bind-attr
branch
from
bc3fe64
to
36b8f3b
Compare
|
No more {{bind-att}} test fails only on phantom? passes in qunit. is there a known configuration issue |
|
@billybonks when I test locally, it works, so I am going to merge this PR. I'm not sure why its not passing in travis. We are still cleaning up/setting up testing, so maybe its something there. |
|
cool, did you run the tests, using ember test or via the browser? |
|
ember test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
{{bind-attr}}the white space commit fixes things like this.