Ember 3.5 upgrade #1541

AaronTJDev · 2018-10-23T02:00:59Z

Fixes #[1528].

Changes proposed in this pull request:

Upgraded ember-source, ember-data, and ember-cli from 2.18 to 3.5
Explicitly binded onclick events in template files, edit-panel.hbs, modal-dialog.hbs, and section.hbs, to get rid of compilation error.
Changed requires to imports in "tests/electron.js" & "tests/ember-electron/main.js", to get rid of compilation errors.

cc @HospitalRun/core-maintainers

jsf-clabot · 2018-10-23T02:01:00Z

All committers have signed the CLA.

donaldwasserman · 2018-10-23T13:31:22Z

Hey @AaronTJDev Thanks for the help.

So I forgot that ember 3.4 introduced stricter template linting rules by default.

@MatthewDorner - What's your thinking on this? Should we ignore the template linting rules and then turn them back on, or try to fix them all up front?

@AaronTJDev Would you be willing to give the template linting rules a stab?

AaronTJDev · 2018-10-23T15:08:13Z

@donaldwasserman Well, l was working on resolving that, but honestly I'm kind of lost on the template-linting issue. I tried running an "eslint --fix" on it, but it wasn't effective. Only thing that was working for me was disabling rules. Are there any automated tools that you could suggest that I look into?

donaldwasserman · 2018-10-23T15:48:28Z

@AaronTJDev There's two solutions:

Disable the rules in a .template-lintrc.js

module.exports = {
  extends: 'recommended',
  ignore: ['node_modules/*'],
  rules: {
    'simple-unless': false,
    'link-rel-noopener': false,
    'attribute-indentation': false,
  }
};

This is copied and pasted from my work's template lint file, so we'd want different values

Is just fix the issues.
Is fix all the issues that have a handlful of instances by hand, and then create tickets to do the rest.

There may be some functionality in VSCode to deal with this. I'll ask around (I'm not personally a VSCode user)

AaronTJDev · 2018-10-23T17:46:13Z

So I was looking into the VS Code linting options and found this , https://youtu.be/qYOw2z6Og8I, I already have vs code but don't use it either, so I'll look into it when I have some time.

MatthewDorner · 2018-10-23T20:26:35Z

server/config-example.js

-config.couchAuthDbURL = config.getProtocol(config.couchDbUseSsl) + config.couchCredentials() + config.couchDbServer + ':' + config.couchDbPort;
-// config.searchURL = 'http:https://localhost:9200'; ELASTIC SEARCH URL (OPTIONAL)
-config.serverInfo = 'Development Ember CLI server';
-module.exports = config;


This file shouldn't get deleted.

MatthewDorner · 2018-10-23T22:51:46Z

I tried the VSCode thing, I think it only works for .js ESLint though, not .hbs ember-template-lint. I am not very familiar with configuring these linters, or even with the upgrade process generally. But any things I can work on to help, I will.

Regarding the template errors, seems like a separate task. If there's a way to do it quickly now then we should, but otherwise later.

I'm getting more errors on "ember test" than just lint errors so maybe just get this to the point it passes all tests, and then decide what else we should do now and what later.

Also @AaronTJDev how did those "avoid-leaking-state-in-components" errors you were discussing in Slack get resolved?

MatthewDorner · 2018-10-24T01:10:25Z

This extension works for VSCode https://marketplace.visualstudio.com/items?itemName=emberjs.vscode-ember, but doesn't have auto fix.

Most common violations are for 'quotes' (must use double quotes) which we can probably fix easily, and then this 'attribute-indentation' as seen in the screenshot. I don't even like that one.

Aside from those 2, there are 269 remaining instances of various types, that somebody can fix but will take a while. A lot of them don't seem like they would be fixable automatically even if there was such a tool.

AaronTJDev · 2018-10-24T01:54:54Z

@donaldwasserman @MatthewDorner Alright, so for now I'll just disable the template lint rules until I can get "ember test" to pass all tests. Also, will restore the config-example.js. As far as the "avoid-leaking-state-in-components" errors, it was an error in how I had resolved the merge conflicts after running ember-cli-update, so I just started from scratch by cloning the repo again and ran a "git checkout --their ." I believe.

donaldwasserman · 2018-10-24T13:09:26Z

README.md

@@ -130,6 +130,16 @@ If you would like to load sample data, you can do so by navigating to **Load DB*

 ![Load DB screenshot](screenshots/load-db.png)

+<<<<<<< HEAD


Looks like there is a merge conflict here.

donaldwasserman · 2018-10-24T13:11:52Z

package.json

 "start": "node script/server.js",
 "test": "ember test",
 "electron-test": "ember electron:test",
 "translation-sync": "babel-node script/translation/sync.js --presets es2015 && eslint --fix app/locales",
 "stylelint": "stylelint 'app/styles/**/*.scss'"
 },
- "repository": {


Looks like some of these properties got deleted

donaldwasserman · 2018-10-24T13:12:36Z

package.json

 "ember-browserify": "^1.1.12",
- "ember-cli": "2.17.1",
+ "ember-cli": "~3.5.0",


Can you pin this to 3.5.0 instead of ~3.5.0?

Suggested change

"ember-cli": "~3.5.0",

"ember-cli": "3.5.0",

donaldwasserman · 2018-10-24T13:12:56Z

package.json

 "ember-concurrency": "0.8.21",
 "ember-concurrency-test-waiter": "0.3.1",
- "ember-data": "2.18.2",
+ "ember-data": "~3.5.0",


See comment about ember-cli versioning

donaldwasserman · 2018-10-24T13:13:12Z

package.json

 "ember-radio-buttons": "^4.0.1",
 "ember-rapid-forms": "^1.2.5",
 "ember-resolver": "^5.0.1",
 "ember-simple-auth": "^1.5.1",
 "ember-sinon-qunit": "3.2.0",
- "ember-source": "2.18.2",
+ "ember-source": "~3.5.0",


See comment about ember cli versioning

donaldwasserman · 2018-10-24T13:15:34Z

@AaronTJDev That sounds good. I'll look into finding some more automated solutions for handling the template linting errors automatically.

AaronTJDev · 2018-11-02T19:42:54Z

@MatthewDorner Alright, so I took a step back from this for about a week because I was having a ton of trouble getting the tests to pass. After coming back to it, I realized that it looks like the way the tests are performed have changed.

2.14

3.5

MatthewDorner · 2018-11-02T21:39:21Z

Might we want to work on this in a new branch instead of master, so we can separate tasks into multiple smaller PRs?

MatthewDorner · 2018-11-02T22:59:19Z

regarding the tests, looks like we can try this https://github.com/rwjblue/ember-qunit-codemod

donaldwasserman · 2018-11-02T23:26:49Z

@MatthewDorner @AaronTJDev I've used the Qunit Codemod and it works really well. I'd say if all the tests pass after you run it, let's just keep it on master.

If there are more problems, breaking up is probably the right call

AaronTJDev · 2018-11-03T04:17:51Z

@MatthewDorner @donaldwasserman Yeah I'm still getting a lot of trouble out of it, breaking up may be the way to go. I tried running ember-qunit-codemod, as well as ember-test-helpers-codemod with little success.

AaronTJDev added 3 commits October 18, 2018 23:49

3.5_Upgrade

ce57e44

3.5

c06bd92

Successful 3.5 build. after binding onclick events on template files.

3e2b129

Reverted imports to requires because of travis.ci failure.

a603237

AaronTJDev closed this Oct 23, 2018

AaronTJDev reopened this Oct 23, 2018

MatthewDorner reviewed Oct 23, 2018

View reviewed changes

donaldwasserman suggested changes Oct 24, 2018

View reviewed changes

AaronTJDev closed this Nov 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ember 3.5 upgrade #1541

Ember 3.5 upgrade #1541

AaronTJDev commented Oct 23, 2018

jsf-clabot commented Oct 23, 2018 •

edited

Loading

donaldwasserman commented Oct 23, 2018

AaronTJDev commented Oct 23, 2018

donaldwasserman commented Oct 23, 2018

AaronTJDev commented Oct 23, 2018

MatthewDorner Oct 23, 2018

MatthewDorner commented Oct 23, 2018

MatthewDorner commented Oct 24, 2018

AaronTJDev commented Oct 24, 2018

donaldwasserman Oct 24, 2018

donaldwasserman Oct 24, 2018

donaldwasserman Oct 24, 2018

donaldwasserman Oct 24, 2018

donaldwasserman Oct 24, 2018

donaldwasserman commented Oct 24, 2018

AaronTJDev commented Nov 2, 2018

MatthewDorner commented Nov 2, 2018

MatthewDorner commented Nov 2, 2018

donaldwasserman commented Nov 2, 2018

AaronTJDev commented Nov 3, 2018 •

edited

Loading

		@@ -130,6 +130,16 @@ If you would like to load sample data, you can do so by navigating to *Load DB

		![Load DB screenshot](screenshots/load-db.png)

		<<<<<<< HEAD

Ember 3.5 upgrade #1541

Ember 3.5 upgrade #1541

Conversation

AaronTJDev commented Oct 23, 2018

jsf-clabot commented Oct 23, 2018 • edited Loading

donaldwasserman commented Oct 23, 2018

AaronTJDev commented Oct 23, 2018

donaldwasserman commented Oct 23, 2018

AaronTJDev commented Oct 23, 2018

MatthewDorner Oct 23, 2018

Choose a reason for hiding this comment

MatthewDorner commented Oct 23, 2018

MatthewDorner commented Oct 24, 2018

AaronTJDev commented Oct 24, 2018

donaldwasserman Oct 24, 2018

Choose a reason for hiding this comment

donaldwasserman Oct 24, 2018

Choose a reason for hiding this comment

donaldwasserman Oct 24, 2018

Choose a reason for hiding this comment

donaldwasserman Oct 24, 2018

Choose a reason for hiding this comment

donaldwasserman Oct 24, 2018

Choose a reason for hiding this comment

donaldwasserman commented Oct 24, 2018

AaronTJDev commented Nov 2, 2018

MatthewDorner commented Nov 2, 2018

MatthewDorner commented Nov 2, 2018

donaldwasserman commented Nov 2, 2018

AaronTJDev commented Nov 3, 2018 • edited Loading

jsf-clabot commented Oct 23, 2018 •

edited

Loading

AaronTJDev commented Nov 3, 2018 •

edited

Loading