This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Use fallback translations #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 18, 2018 17:18
…d missing message behaviour to lookup translation in default language
stukalin
approved these changes
Jul 19, 2018
|
Tests are currently failing because of this issue with the newer version of ember-i18n in Electron. I imagine this is also the reason #1428 is failing. For now I'm going to revert to the older version of ember-i18n as that wasn't the main change here. |
This was referenced Nov 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1457
The problem I encounted when creating this PR is that Ember-i18n's Default Locale Fallback works when the key is missing from the translation but I would prefer to include the key and provide a value which allows translation contributors to see more easily what translation keys are defined.
I cannot use empty string as has previously been used because Ember-i18n will not call missing message so instead I've updated this to be undefined.
Then I added a function for missing message which uses the default locale which I took from here jamesarosen/ember-i18n#256 (comment)
Changes proposed in this pull request:
app/utils/i18n/missing-message.js