Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Update translations.js #1201

Closed
wants to merge 2 commits into from
Closed

Update translations.js #1201

wants to merge 2 commits into from

Conversation

nongpp
Copy link

@nongpp nongpp commented Sep 13, 2017

add German language.

Fixes #[replace brackets with the issue number that your pull request addresses].

Changes proposed in this pull request:

  • [list out summary of changes here]
  • [list out summary of changes here]
  • [list out summary of changes here]
  • [etc]

Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text)

cc @HospitalRun/core-maintainers

add German language.
@jsf-clabot
Copy link

jsf-clabot commented Sep 13, 2017

CLA assistant check
All committers have signed the CLA.

@nongpp
Copy link
Author

nongpp commented Sep 13, 2017

Sorry for did not sign your Contributor License Agreement in the first time, Now I already sign it. And thank you for checked my pull request.

Copy link

@NatJNP NatJNP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great for add translation.js

Copy link

@tonconan tonconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to do other languages

@tangollama
Copy link
Member

Before we consider merging this, we need someone who actually reads and speaks German to review and approve this.

@yindia
Copy link
Contributor

yindia commented Sep 30, 2017

@tangollama right,translation review should be done by someone who actually reads and speaks that language

@tangollama
Copy link
Member

@nongpp I've inquired for a German language reviewer from the community's Slack. Hopefully, someone will respond.

@LucaDev
Copy link

LucaDev commented Oct 2, 2017

Some of these translations are only half translated and still include some English words

Copy link

@unused unused left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm missing the context for BillingDiagnosis and Imaging, the rest should be OK - if you need an extended review let me know.

newForm: '',
preview: ''
addField: 'Feld hinzufügen',
moveDown: 'Sich abwärts bewegen',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nach unten verschieben

addField: 'Feld hinzufügen',
moveDown: 'Sich abwärts bewegen',
moveUp: 'Nach oben verschieben',
newForm: '+ neues formular',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Neues Formular

visitFormType: ''
alwaysInclude: 'Immer einschließen',
checkbox: 'Checkbox',
colSpan: 'Anzahl der Spalten zum Spannen',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anzahl der Spalten

alwaysInclude: 'Immer einschließen',
checkbox: 'Checkbox',
colSpan: 'Anzahl der Spalten zum Spannen',
columns: 'Säulen',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spalten

checkbox: 'Checkbox',
colSpan: 'Anzahl der Spalten zum Spannen',
columns: 'Säulen',
customForm: 'Kundenspezifisches Formular',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eigenes Formular

addImaging: 'Imaging hinzufügen',
addIncident: 'Vorfall hinzufügen',
addIncidentCategory: 'Incident Kategorie hinzufügen',
addInventoryItem: 'Inventory Item hinzufügen',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inventar hinzufügen

addIncident: 'Vorfall hinzufügen',
addIncidentCategory: 'Incident Kategorie hinzufügen',
addInventoryItem: 'Inventory Item hinzufügen',
addInventoryPurchase: 'Inventory Purchase hinzufügen',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inventar Einkauf hinzufügen

addIncidentCategory: 'Incident Kategorie hinzufügen',
addInventoryItem: 'Inventory Item hinzufügen',
addInventoryPurchase: 'Inventory Purchase hinzufügen',
addInventoryRequest: 'Inventaranforderung hinzufügen',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inventar Anfrage hinzufügen

labs: 'Labs',
listPaidInvoices: 'Liste bezahlter Rechnungen',
loadDb: 'Datenbank laden',
manageIncidents: 'Verwalten von Vorfall',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verwalten von Vorfällen

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vorfälle verwalten

loadDb: 'Datenbank laden',
manageIncidents: 'Verwalten von Vorfall',
medication: 'Medikation',
overrideInvoice: 'Override Rechnung',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rechnung überschreiben

@nponiros
Copy link

nponiros commented Oct 2, 2017

I had a quick look. There are a number of spelling mistakes and not everything is translated. Depending on the context in which the text is used, there might also be some wrong translations. In case nobody else can help, I might be able to commit some fixes over the weekend. Just let me know.

@jglovier
Copy link
Member

jglovier commented Oct 2, 2017

Thanks for the feedback, everyone! ❤️

@nongpp could you please incorporate the feedback provided and make changes to your pull request accordingly? Thank you!

@caugner
Copy link

caugner commented Oct 3, 2017

What I would recommend is to split this up into two commits and have the first commit just copy the English translation to the de-folder and the second commit actually translate. Like this reviewers can have a look at the second commit and review in the context of the original.

formName: 'Formularname',
formType: 'Formulartyp',
incidentFormType: 'Vorfall',
includeOtherOption: 'Include Andere Option',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andere Option hinzufügen

includeOtherOption: 'Include Andere Option',
labFormType: 'Labor',
label: 'Etikette',
newForm: 'Neue Form',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neues Formular

messages: { headerSaved: '' },
newTitle: '',
titles: { optionsSaved: '' }
editTitle: 'Header-Optionen',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Überschrift Titel

progressMessage: '',
progressTitle: ''
displayAlertMessage: 'Bitte wählen Sie die zu ladende Datei aus.',
displayAlertTitle: 'Wählen Sie Datei zum Laden aus',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wählen sie eine Datei zum Laden aus

@tangollama
Copy link
Member

@nongpp any chance you're planning to address the recommended changes?

@tangollama tangollama closed this Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet