-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Conversation
add German language.
Sorry for did not sign your Contributor License Agreement in the first time, Now I already sign it. And thank you for checked my pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great for add translation.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to do other languages
Before we consider merging this, we need someone who actually reads and speaks German to review and approve this. |
@tangollama right,translation review should be done by someone who actually reads and speaks that language |
@nongpp I've inquired for a German language reviewer from the community's Slack. Hopefully, someone will respond. |
Some of these translations are only half translated and still include some English words |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing the context for BillingDiagnosis and Imaging, the rest should be OK - if you need an extended review let me know.
newForm: '', | ||
preview: '' | ||
addField: 'Feld hinzufügen', | ||
moveDown: 'Sich abwärts bewegen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nach unten verschieben
addField: 'Feld hinzufügen', | ||
moveDown: 'Sich abwärts bewegen', | ||
moveUp: 'Nach oben verschieben', | ||
newForm: '+ neues formular', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Neues Formular
visitFormType: '' | ||
alwaysInclude: 'Immer einschließen', | ||
checkbox: 'Checkbox', | ||
colSpan: 'Anzahl der Spalten zum Spannen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anzahl der Spalten
alwaysInclude: 'Immer einschließen', | ||
checkbox: 'Checkbox', | ||
colSpan: 'Anzahl der Spalten zum Spannen', | ||
columns: 'Säulen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spalten
checkbox: 'Checkbox', | ||
colSpan: 'Anzahl der Spalten zum Spannen', | ||
columns: 'Säulen', | ||
customForm: 'Kundenspezifisches Formular', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eigenes Formular
addImaging: 'Imaging hinzufügen', | ||
addIncident: 'Vorfall hinzufügen', | ||
addIncidentCategory: 'Incident Kategorie hinzufügen', | ||
addInventoryItem: 'Inventory Item hinzufügen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inventar hinzufügen
addIncident: 'Vorfall hinzufügen', | ||
addIncidentCategory: 'Incident Kategorie hinzufügen', | ||
addInventoryItem: 'Inventory Item hinzufügen', | ||
addInventoryPurchase: 'Inventory Purchase hinzufügen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inventar Einkauf hinzufügen
addIncidentCategory: 'Incident Kategorie hinzufügen', | ||
addInventoryItem: 'Inventory Item hinzufügen', | ||
addInventoryPurchase: 'Inventory Purchase hinzufügen', | ||
addInventoryRequest: 'Inventaranforderung hinzufügen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inventar Anfrage hinzufügen
labs: 'Labs', | ||
listPaidInvoices: 'Liste bezahlter Rechnungen', | ||
loadDb: 'Datenbank laden', | ||
manageIncidents: 'Verwalten von Vorfall', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verwalten von Vorfällen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vorfälle verwalten
loadDb: 'Datenbank laden', | ||
manageIncidents: 'Verwalten von Vorfall', | ||
medication: 'Medikation', | ||
overrideInvoice: 'Override Rechnung', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rechnung überschreiben
I had a quick look. There are a number of spelling mistakes and not everything is translated. Depending on the context in which the text is used, there might also be some wrong translations. In case nobody else can help, I might be able to commit some fixes over the weekend. Just let me know. |
Thanks for the feedback, everyone! ❤️ @nongpp could you please incorporate the feedback provided and make changes to your pull request accordingly? Thank you! |
What I would recommend is to split this up into two commits and have the first commit just copy the English translation to the de-folder and the second commit actually translate. Like this reviewers can have a look at the second commit and review in the context of the original. |
formName: 'Formularname', | ||
formType: 'Formulartyp', | ||
incidentFormType: 'Vorfall', | ||
includeOtherOption: 'Include Andere Option', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Andere Option hinzufügen
includeOtherOption: 'Include Andere Option', | ||
labFormType: 'Labor', | ||
label: 'Etikette', | ||
newForm: 'Neue Form', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neues Formular
messages: { headerSaved: '' }, | ||
newTitle: '', | ||
titles: { optionsSaved: '' } | ||
editTitle: 'Header-Optionen', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Überschrift Titel
progressMessage: '', | ||
progressTitle: '' | ||
displayAlertMessage: 'Bitte wählen Sie die zu ladende Datei aus.', | ||
displayAlertTitle: 'Wählen Sie Datei zum Laden aus', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wählen sie eine Datei zum Laden aus
@nongpp any chance you're planning to address the recommended changes? |
add German language.
Fixes #[replace brackets with the issue number that your pull request addresses].
Changes proposed in this pull request:
Note: pull requests without proper descriptions may simply be closed without further discussion. We appreciate your contributions, but need to know what you are offering in clearly described format. Thanks! (you can delete this text)
cc @HospitalRun/core-maintainers