Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Add "Patient Listing" button to patient update confirmation dialog #230

Closed
jglovier opened this issue Dec 8, 2015 · 3 comments
Closed

Comments

@jglovier
Copy link
Member

jglovier commented Dec 8, 2015

screen shot 2015-12-07 at 8 11 28 pm

Once you create a new patient record, or update an existing record, you get a confirmation dialog that basically just dismisses the dialog. There is a good chance once you're done updating the record you simply want to return to the Patient Listing index view, so lets put a button on that dialog that lets you go directly there so you don't have to click "Ok" to confirm, then scroll all the way back up to the listing and click there instead because efficiency.

@BrianHC
Copy link

BrianHC commented Dec 10, 2015

Hi, I am interested in helping out on this project. Could I take a shot at implementing this request?

@tangollama
Copy link
Member

Absolutely. Swing away.

Typed or dictated imperfectly on my iPhone (717.385.9970)

On Dec 9, 2015, at 10:26 PM, capurp [email protected] wrote:

Hi, I am interested in helping out on this project. Could I take a shot at implementing this request?


Reply to this email directly or view it on GitHub.

@BrianHC
Copy link

BrianHC commented Dec 10, 2015

Awesome! Thanks. I am still getting familiar with ember and trying to understand the application repo. So I apologize in advance if this fix will take a bit longer to implement... I appreciate any advice anyone can provide me with! I am going through the ember tutorials and seeing if I can find where the concepts are applied within the application.

BrianHC added a commit to BrianHC/hospitalrun-frontend that referenced this issue Jan 17, 2016
HospitalRun#230 (comment)

~\app\patients\edit\controller.js
Updated "afterUpdate" action to not use displayAlert. The display alert
was a helper function that helped users quickly open a message dialog.
Instead the "afterUpdate" action will now call a new dialog directly and
bypass the displayAlert helper class. The new updated afterUpdate action
specifies that the update button will call an action to bring the user
back to the patient list. The action that the updateButtonAction is set
to is called 'returnToPatient', this action has been added to the
controller file and the route file.

~\app\patients\edit\route.js
Added new action 'returnToPatient' points to the action in the
controller file.

~\app\templates\components\modal-dialog.hbs
Updated the model dialogue template to allow users to customize the
cancel button. In order to customize the cancel button you must set the
flag {{isCancelTextChanged}} to true and then set  {{cancelButtonText}}
to the text that you want to be displayed instead. If you do not have
the flag set to true, then the template will render the default cancel
button that has the text "Cancel" The reason for setting a flag is so
that other dialogs that use this template can continue to work normally
without having to go back to modify and set {{canceButtonText}} for
every instance of the template.

~\app\components\modal-dialog.js
Updated component to capture the custom text and flag if they wish to
customize the text

~\app\dialog\template.hbs
Updated the mapping to capture the user input.
matteovivona pushed a commit that referenced this issue Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants