Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Warn about missing translations #1919

Closed
jackcmeyer opened this issue Mar 18, 2020 · 3 comments 路 Fixed by #2034
Closed

Warn about missing translations #1919

jackcmeyer opened this issue Mar 18, 2020 · 3 comments 路 Fixed by #2034
Labels
馃殌enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions
Projects
Version 2.0
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

馃殌 Feature Proposal

I would like the application to warn about missing translations when starting the application or running tests.

A preferable solution would be to have a library that does this for us, which could mean switching internationalization libraries.

However, as a fallback, a custom script that runs as part of yarn start or yarn test should work as well.

Motivation

Translations are very hard to manage and they get out of sync very quickly.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 18, 2020
@jackcmeyer jackcmeyer added the 馃殌enhancement an issue/pull request that adds a feature to the application label Mar 18, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 18, 2020
@jackcmeyer jackcmeyer added the help wanted indicates that an issue is open for contributions label Mar 18, 2020
@martimfj
Copy link
Contributor

Hey Jack!

I agree, I`ve just added a few of the missing translations. A script that compares the english translation files to the others (languages) and adds a default, would be nice too.

@fox1t
Copy link
Member

fox1t commented Mar 23, 2020

I agree that might be helpful have a script that checks the status of translations file. We can run it on CI/CD in a non-blocking fashion: we can display a warning.

@marcosvega91 marcosvega91 mentioned this issue May 2, 2020
Merged
@marcosvega91
Copy link
Contributor

marcosvega91 commented May 2, 2020 •
edited
Loading

Hi guys I have added a new command to check missing translations comparing every language with the english one.
In the future I think that you could integrate an external service like Crowdin.
The script could:

  1. Send english translations to service
  2. Download translations for all languages from the service
  3. Update missing translations in locals folder

I remember that Crowdin is free for opensource project
Docusaurus uses this service

@marcosvega91 marcosvega91 mentioned this issue May 30, 2020
Open
Version 2.0 automation moved this from To do to Done Jun 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
馃殌enhancement an issue/pull request that adds a feature to the application help wanted indicates that an issue is open for contributions
Projects
Version 2.0
  
Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

feat(i18n): add new script for checking missing translations
4 participants
@fox1t @marcosvega91 @martimfj @jackcmeyer