I can work on this.

@MatthewDorner all yours!

I would wait until #1738 gets merged to start implementing the database stuff, since this should provide a nice function to update fields with.

However, this shouldn't block doing some of the UI part of this work.

@MatthewDorner nice!

@jackcmeyer #1738 merged

Still working on this. Trying to see if I can just use the GeneralInformation form as New/Edit patient instead of having additional form, but getting in trouble with logic around saving and loading the model, Redux state, and state + props for the form.

I found the code for loading Patients is also currently bugged. The Spinner in ViewPatient never gets shown because it's checking for !patient, but useSelector returns an empty object when patient state is empty. But even if we did check for empty object this wouldn't suffice as the patient state could already be loaded with an old Patient you were looking at and there's no way to tell the difference.

Also if you view one Patient with all the fields filled in and then go view a Patient where those fields are supposed to be blank, you will still see the values from the first Patient in those fields, but I think this is a separate bug.

I'm digging into why the component is not updating when the new patient gets loaded.

The store is getting updated, but the component is not reflecting those changes.

It must be something to do with empty strings.

After further investigation,

This seems like an issue with The TextInput and TextField components in the hospitalrun/components library.

I verified and all of components are getting passed the proper data, however, TextInput and TextField are just not displaying them properly.

I verified this by swapping out TextInput and TextField with just a normal input field and in TextFieldWithLabelFormGroup and TextInputWithLabelFormGroup and the screen worked as expected.

I've opened an issue here to track the work: HospitalRun/components#259

It must be something to do with empty strings.

I really want to avoid passing empty strings for "signaling" that is a new patient. Do you have any alternative ideas, @MatthewDorner ?

After further investigation,

This seems like an issue with The TextInput and TextField components in the hospitalrun/components library.

I verified and all of components are getting passed the proper data, however, TextInput and TextField are just not displaying them properly.

I verified this by swapping out TextInput and TextField with just a normal input field and in TextFieldWithLabelFormGroup and TextInputWithLabelFormGroup and the screen worked as expected.

I've opened an issue here to track the work: HospitalRun/components#259

Good findings @jackcmeyer!

I've written a draft that I think will work. It uses GeneralInformation as the form for New, Edit, and View Patient, and NewPatient, EditPatient, ViewPatient containers that manage fetching and saving data and which contain the state.

MatthewDorner/hospitalrun-frontend@MatthewDorner:master...MatthewDorner:edit-patient-draft-3

I have to fix all the tests now, so while I do that, any comments or suggestions are welcome.

EDIT: Also kind of changed Approximate Age and DOB stuff in merging the two forms. Now it only shows either Date of Birth OR Approximate Age, based on whether the "Unknown" is checked, I can make it different if desired. Also the checkbox has no way to set its value, no value prop so that doesn't work exactly right.

If you want, feel free to open a PR so we can discuss it there.