Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Layout of navigation needs some fixes #122

Closed
jkleinsc opened this issue Jul 8, 2015 · 16 comments
Closed

Layout of navigation needs some fixes #122

jkleinsc opened this issue Jul 8, 2015 · 16 comments
Assignees
Labels
🐛bug issue/pull request that documents/fixes a bug

Comments

@jkleinsc
Copy link
Member

jkleinsc commented Jul 8, 2015

There is an unneeded scrollbar on the navigation pane and the search icon is not in the right place. See attached screenshot:
screen shot 2015-07-08 at 12 26 08 pm

@jkleinsc jkleinsc added 🐛bug issue/pull request that documents/fixes a bug design labels Jul 8, 2015
@jglovier
Copy link
Member

jglovier commented Jul 8, 2015

What OS/Browser/Ver are you on?

@jglovier
Copy link
Member

jglovier commented Jul 8, 2015

This is how it looks for me.

image

@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 8, 2015

OSX Yosemite Chrome 43

@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 8, 2015

I still don't understand why you would use overflow: scroll

@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 8, 2015

FYI... this is using the master branch

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

I can't reproduce this. Can we setup a time to screenshare with Screenhero and I can try to diagnose on your machine?

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

One thing that's bizarre that stands out to me in your screenshot is the scrollbar styling. Even when scrollbars are present for me in Chrome, they don't affect the layout, and they don't have a white background, they have a transparent background.

image

It almost seems like you're using a completely different browser than me?

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

You're not in a VM or something, right?

@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 9, 2015

@jglovier I just verified this. When I plugin an external monitor, I get the white scrollbars. When I unplug, I get the black scrollbars. Its some weird mac thing. Here is someone else on SO getting the same issue:
http:https://stackoverflow.com/questions/21157231/mac-os-x-scrollbar-is-sometimes-white-transparent-and-sometimes-black-transpare

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

🆒 That's so strange, because I'm on an external monitor and I can't reproduce this. Anyway, glad you found the fix. Thx.

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

Also, the SO issue you linked to had to do with the scrollbar color itself, but not the appearance of a scrollbar background that affects the box layout. So that doesn't really explain it.

@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 9, 2015

@jglovier it was my external mouse. When I plugged it in it caused the scrollbars to show. I changed the setting here for Show scroll bars from Automatically based on mouse or trackpad to When scrolling and not it always shows the black bar and only when scrolling:
screen shot 2015-07-09 at 11 58 23 am

@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 9, 2015

@jglovier BTW -- I think if we left the overflow: scroll in the issue would reproduce in Windows because windows doesn't automatically hide scrollbars, but this feature in OSX does.

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

@jkleinsc whoaaaaa interesting. Good find. 🔍 👀 👍

Reopening because I should address the breakage of the search bar regardless. That's a bit too fragile for my comfort, and who knows what else might trigger those scrollbars (e.g. a scenario where the scrollbar does need to appear for content, and the user has a mouse...like in the Philippines I'm guessing lol).

@jglovier jglovier reopened this Jul 9, 2015
@jkleinsc
Copy link
Member Author

jkleinsc commented Jul 9, 2015

I think I you factor in for a slightly wider scroll bar it would solve the search icon wrapping to the next line.

Sent from my mobile device

On Jul 9, 2015, at 12:23 PM, Joel Glovier [email protected] wrote:

Whoaaaaa interesting. Good find.

Reopening because I should address the breakage of the search bar regardless. That's a bit too fragile for my comfort, and who knows what else might trigger those scrollbars (e.g. a scenario where the scrollbar does need to appear for content, and the user has a mouse...like in the Philippines I'm guessing lol).


Reply to this email directly or view it on GitHub.

@jglovier
Copy link
Member

jglovier commented Jul 9, 2015

Yup. 👍

jglovier pushed a commit that referenced this issue Jul 10, 2015
matteovivona pushed a commit that referenced this issue Jan 15, 2021
Convert NewAllergyModal.test.tsx to RTL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐛bug issue/pull request that documents/fixes a bug
Projects
None yet
Development

No branches or pull requests

2 participants