fix(lab): required visit not enforced

package.json

@@ -5,7 +5,7 @@
  "private": false,
  "license": "MIT",
  "dependencies": {
- "@hospitalrun/components": "~3.3.0",
+ "@hospitalrun/components": "~3.4.0",
  "@reduxjs/toolkit": "~1.5.0",
  "@types/escape-string-regexp": "~2.0.1",
  "@types/json2csv": "~5.0.1",

src/__tests__/labs/requests/NewLabRequest.test.tsx

@@ -185,6 +185,7 @@ describe('New Lab Request', () => {
  message: 'some message',
  patient: 'some patient message',
  type: 'some type error',
+ visit: 'some visit error',
  } as LabError
 
  it('should display errors', async () => {
@@ -198,13 +199,16 @@ describe('New Lab Request', () => {
  const alert = await screen.findByRole('alert')
  const patientInput = screen.getByPlaceholderText(/labs\.lab\.patient/i)
  const typeInput = screen.getByLabelText(/labs\.lab\.type/i)
+ const visit = screen.getByPlaceholderText('-- Choose --')
 
  expect(within(alert).getByText(error.message)).toBeInTheDocument()
  expect(within(alert).getByText(/states\.error/i)).toBeInTheDocument()
  expect(alert).toHaveClass('alert-danger')
  expect(patientInput).toHaveClass('is-invalid')
  expect(typeInput).toHaveClass('is-invalid')
  expect(typeInput.nextSibling).toHaveTextContent(error.type as string)
+ expect(visit).toHaveClass('is-invalid')
+ screen.getByText(error.visit as string)
  })
  })
 

src/labs/requests/NewLabRequest.tsx

@@ -152,6 +152,7 @@ const NewLabRequest = () => {
  isRequired
  isEditable={newLabRequest.patient !== undefined}
  isInvalid={!!error?.visit}
+ feedback={t(error?.visit as string)}
  options={visitOptions || []}
  defaultSelected={defaultSelectedVisitsOption()}
  onChange={(values) => {

src/shared/components/input/SelectWithLabelFormGroup.tsx

@@ -18,6 +18,7 @@ interface Props {
  multiple?: boolean
  isEditable?: boolean
  isInvalid?: boolean
+ feedback?: string
 }
 
 const SelectWithLabelFormGroup = (props: Props) => {
@@ -32,6 +33,7 @@ const SelectWithLabelFormGroup = (props: Props) => {
  multiple,
  isEditable,
  isInvalid,
+ feedback,
  } = props
  const id = `${name}Select`
  return (
@@ -46,6 +48,7 @@ const SelectWithLabelFormGroup = (props: Props) => {
  multiple={multiple}
  disabled={!isEditable}
  isInvalid={isInvalid}
+ feedback={feedback}
  />
  </div>
  )