Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno 1.38.2 #153128

Merged
merged 2 commits into from
Nov 18, 2023
Merged

deno 1.38.2 #153128

merged 2 commits into from
Nov 18, 2023

Conversation

ZhongRuoyu
Copy link
Member

@ZhongRuoyu ZhongRuoyu commented Nov 2, 2023

Created with brew bump-formula-pr.

  • resource blocks have been checked for updates.

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` long build Set a long timeout for formula testing labels Nov 2, 2023
@chenrui333 chenrui333 added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 3, 2023
@chenrui333 chenrui333 removed CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. long build Set a long timeout for formula testing labels Nov 3, 2023
@github-actions github-actions bot added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 3, 2023
@chenrui333 chenrui333 added the long build Set a long timeout for formula testing label Nov 3, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 3, 2023
@ZhongRuoyu ZhongRuoyu added CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Nov 3, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 3, 2023
@chenrui333
Copy link
Member

Minitest::Assertion: No linkage with libsqlite3.dylib! Cargo is likely using a vendored version.

@chenrui333 chenrui333 added the test failure CI fails while running the test-do block label Nov 3, 2023

This comment was marked as resolved.

@github-actions github-actions bot added the stale No recent activity label Nov 6, 2023
@ZhongRuoyu ZhongRuoyu added in progress Stale bot should stay away and removed stale No recent activity labels Nov 6, 2023
@vwkd vwkd mentioned this pull request Nov 7, 2023
6 tasks
@mmastrac
Copy link
Contributor

mmastrac commented Nov 7, 2023

We added a new reference to sqlite in the denokv_sqlite crate which is likely breaking the unvendoring script. Unvendoring sqlite fully may require editing Cargo.lock rather than Cargo.toml, but we can take some patches upstream to help unvendor.

@chenrui333
Copy link
Member

@mmastrac happy to try out any build patch.

@mmastrac
Copy link
Contributor

mmastrac commented Nov 10, 2023

@chenrui333 I finally figured out what the probable fix is:

Can you try patching this? We can probably fix it by 1.38.2.

    inreplace "Cargo.toml",
              /^denokv_sqlite = "0.2.1"$/,
              'denokv_sqlite = { default-features = false, version = "0.2.1" }'

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 11, 2023
kt3k pushed a commit to denoland/deno that referenced this pull request Nov 17, 2023
@ZhongRuoyu ZhongRuoyu changed the title deno 1.38.1 deno 1.38.2 Nov 17, 2023
@ZhongRuoyu ZhongRuoyu added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 17, 2023
@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 17, 2023
@ZhongRuoyu ZhongRuoyu added the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 17, 2023
@mmastrac
Copy link
Contributor

@ZhongRuoyu

With some changes we made in this most recent release, you probably need to add --no-default-features to the cargo build flags. This should hopefully get us past the release problems.

@github-actions github-actions bot removed the CI-long-timeout [DEPRECATED] Use longer GitHub Actions CI timeout. label Nov 18, 2023
@ZhongRuoyu
Copy link
Member Author

Looks like it built fine. Thanks for your help @mmastrac!

@ZhongRuoyu ZhongRuoyu added ready to merge PR can be merged once CI is green and removed test failure CI fails while running the test-do block labels Nov 18, 2023
@mmastrac
Copy link
Contributor

@ZhongRuoyu Great, thanks for getting it working! I'm going to see what we can do to make the build easier for the future.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 18, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 18, 2023
Merged via the queue into Homebrew:master with commit 346cf95 Nov 18, 2023
12 checks passed
@ZhongRuoyu ZhongRuoyu deleted the bump-deno-1.38.0 branch November 18, 2023 02:52
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. in progress Stale bot should stay away long build Set a long timeout for formula testing outdated PR was locked due to age ready to merge PR can be merged once CI is green rust Rust use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants