Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.
After making all changes to a cask, verify:
brew audit --cask {{cask_file}}
is error-free.brew style --fix {{cask_file}}
reports no offenses.Additionally, if adding a new cask: N/A, but...
brew audit --new-cask {{cask_file}}
worked successfully. (didn't check this)brew install --cask {{cask_file}}
worked successfully.brew uninstall --cask {{cask_file}}
worked successfully.Windscribe v2 uses an installer app (as opposed to v1, which just used drag-and-drop). If there is any way to automate installation rather than requiring the user to open the file from Caskroom due to
installer manual
, that would be good to know. However, I have not been able to discover any command-line arguments taken by the installer program that may make this possible.Should v1 be added to homebrew-cask-versions? It is still available on Windscribe.com as "Legacy version".
Also,
brew style --fix
seems to have messed with the indentation of myuninstall launchctl
block (see second commit). Should this "fix" be reverted?