Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck/strategy: verify --fail-with-body support #17356

Merged
merged 1 commit into from
May 24, 2024

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The --fail-with-body flag was added in curl 7.76.0, so systems with an earlier version will need to use brewed curl for page content livechecks to complete successfully.

Before: (curl 7.54.0)

$ brew livecheck zulu@8
curl: option --fail-with-body: is unknown
curl: try 'curl --help' or 'curl --manual' for more information
Error: zulu@8: Unable to get versions

After:

$ brew livecheck zulu@8
zulu@8: 8.0.412,8.78.0.19 ==> 8.0.412,8.78.0.19

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit ea5023a into master May 24, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the verify-fail-with-body branch May 24, 2024 07:29
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants