Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/kernel: make opoo/odie/etc. print GitHub Actions notes. #17255

Merged
merged 1 commit into from
May 9, 2024

Conversation

MikeMcQuaid
Copy link
Member

We already do this for deprecations but these may make warnings and errors from Homebrew easier to spot in GitHub Actions logs.

Maybe we only want to do this for warnings or maybe only for deprecations 🤷🏻. Feedback welcome.

@MikeMcQuaid MikeMcQuaid requested a review from a team May 8, 2024 14:48
Library/Homebrew/extend/kernel.rb Outdated Show resolved Hide resolved
@Bo98 Bo98 mentioned this pull request May 8, 2024
@MikeMcQuaid MikeMcQuaid force-pushed the github_actions_opoo_odie branch 3 times, most recently from 9d36269 to f3a7309 Compare May 9, 2024 08:15
@MikeMcQuaid MikeMcQuaid enabled auto-merge May 9, 2024 08:16
@MikeMcQuaid MikeMcQuaid force-pushed the github_actions_opoo_odie branch 4 times, most recently from bbf360b to e06ba60 Compare May 9, 2024 10:15
@MikeMcQuaid MikeMcQuaid force-pushed the github_actions_opoo_odie branch 2 times, most recently from b9fcdc1 to 27a5558 Compare May 9, 2024 12:19
We already do this for deprecations but these may make warnings
and errors from Homebrew easier to spot in GitHub Actions logs.

While we're here, cleanup other cases that should have used
`GitHub::Actions::Annotation` but didn't and provide some helpers and
tweaks there necessary for our use case here.
@MikeMcQuaid MikeMcQuaid merged commit 7433205 into master May 9, 2024
32 checks passed
@MikeMcQuaid MikeMcQuaid deleted the github_actions_opoo_odie branch May 9, 2024 14:01
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 9, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants