Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend/os/linux/system_config: show glibc/gcc version for API users #15916

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Aug 27, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I noticed that some issue reports showed N/A for glibc/etc even though Homebrew should have installed them.

Locally tried it out on Ubuntu 20.04 container and saw similar behavior, which seems due to API usage, e.g.

OS: Ubuntu 20.04.6 LTS
Host glibc: 2.31
/usr/bin/gcc: 9.4.0
/usr/bin/ruby: N/A
glibc: N/A
gcc@11: N/A
gcc: N/A
xorg: N/A
$ brew info glibc | grep Poured
  Poured from bottle using the formulae.brew.sh API on 2023-08-27 at 04:44:30

I think the original goal of conditional was to avoid auto-tapping homebrew/core, which I guess is only an issue now when API is disabled. May need confirmation that API logic will do what is expected.

Output with change:

OS: Ubuntu 20.04.6 LTS
Host glibc: 2.31
/usr/bin/gcc: 9.4.0
/usr/bin/ruby: N/A
glibc: 2.35_1
gcc@11: N/A
gcc: 13.1.0
xorg: N/A

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks @cho-m!

@MikeMcQuaid MikeMcQuaid merged commit d4444b5 into Homebrew:master Aug 27, 2023
23 of 24 checks passed
@cho-m cho-m deleted the linux-glibc-version-api branch August 27, 2023 21:29
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants