Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thruk: add disabled_backends field to filter out thruk backends (#219) #991

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

fermino
Copy link
Contributor

@fermino fermino commented Nov 28, 2023

This adds support for the feature asked in #219.

@fermino
Copy link
Contributor Author

fermino commented Nov 28, 2023

@HenriWahl I will need some feedback/advice as how to lay out the GUI elements (I hacked it together but pretty sure it could be better). Let me know if there's anything I can improve!

PS: Thanks for maintaining this project :)

@HenriWahl HenriWahl changed the base branch from master to thruk_backend November 30, 2023 12:34
@HenriWahl HenriWahl merged commit e6da242 into HenriWahl:thruk_backend Nov 30, 2023
@HenriWahl
Copy link
Owner

I fixed the GUI a little - the result should be available soon at https://github.com/HenriWahl/Nagstamon/releases/tag/latest with release 3.13-20231130

@fermino
Copy link
Contributor Author

fermino commented Nov 30, 2023

@HenriWahl thank you!!

@fermino
Copy link
Contributor Author

fermino commented Nov 30, 2023

Sorry @HenriWahl wouldn't be necessary to merge thruk_backend into master? Do you want me to modify or test anything?

@HenriWahl
Copy link
Owner

Please test it and if it looks OK it will get into master.

@fermino
Copy link
Contributor Author

fermino commented Nov 30, 2023

@HenriWahl that definitely looks better. I would just make the label Disabled backends (comma separated IDs) or something similar, as it might not be that intuitive to use. Otherwise it looks great!

@HenriWahl
Copy link
Owner

@fermino to avoid such a big label maybe just put that information into a tooltip which pops up at the textfield?

@fermino
Copy link
Contributor Author

fermino commented Dec 4, 2023

@HenriWahl I though about it but I didn't know if it was possible, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants