Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support namecoin standard 'map' for subdomain name #1856

Merged
merged 3 commits into from
Jan 15, 2019

Conversation

rllola
Copy link
Contributor

@rllola rllola commented Jan 13, 2019

See #1843

@HelloZeroNet
Copy link
Owner

Thanks, please use other variable name instead of map (eg. data_map) as it's a built-in function in python and changing it could have some side-effects and rename newValue to new_value to make the variable names consistent within the function.

@rllola
Copy link
Contributor Author

rllola commented Jan 15, 2019

Done.

I have also added a new case I forgot https://github.com/HelloZeroNet/ZeroNet/pull/1856/files#diff-ccde09c3a724251c612f29d91a7751d7R47

It is when you only have :

{
   "zeronet":"19rXKeKptSdQ9qt7omwN82smehzTuuq6S9"
}

I choose to reformat the namecoin standard in the zeronet one and recall the function so I don't have to modify anything in the part where you save it. I hope this is fine. I prefer to make a minimal modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants