Statically allocate UART Receive buffers #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing dynamic UART receive buffer allocation has problematic issues. The malloc() may fail, and the code proceeds with a null buffer. Earlier code failed to free() and ran out of memory.
The current code frees the receive buffer while Rx interrupts are still enabled, causing use-after-free.
For these two fixed-size UART buffers, dynamic allocation is not needed and the code is better served by static allocation.