fix: Messed-up pre-compiler directives in EEPROM library #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This closes HelTecAutomation#188 code is by @gztproject
|
Anyone waiting for this to get merged (or any ohter changes) and working with platformio can use this in the [env:cubecell_module_plus]
platform = [email protected]
platform_packages =
; use upstream Git version
framework-arduinoasrmicro @ https://github.com/ScholliYT/ASR650x-Arduino.git ; TODO: change this back if https://github.com/HelTecAutomation/CubeCell-Arduino/pull/210 gets merged
framework-arduinoasrmicro650x @ https://github.com/ScholliYT/ASR650x-Arduino.git ; TODO: change this back if https://github.com/HelTecAutomation/CubeCell-Arduino/pull/210 gets mergedhttps://github.com/HelTecAutomation/CubeCell-Arduino/pull/210 gets merged
board = cubecell_module_plus
framework = arduinoIDK why there are two packages doing the same thing. But the first one was used by my local machine while the second one was used by a CI pipeline. Anyways, patching both seems to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #188
code is by @gztproject