Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types on backdrop #408

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Fix types on backdrop #408

merged 2 commits into from
Sep 26, 2023

Conversation

NeeEoo
Copy link
Contributor

@NeeEoo NeeEoo commented Sep 25, 2023

This fixes a bug where you cant use any float values on the constructor of the flxbackdrop

Copy link
Member

@Geokureli Geokureli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the format suggested
Edit: I've committed the suggestion, waiting on CI

flixel/addons/display/FlxBackdrop.hx Outdated Show resolved Hide resolved
@NeeEoo
Copy link
Contributor Author

NeeEoo commented Sep 26, 2023

Alr! Could i know why?

@Geokureli
Copy link
Member

Geokureli commented Sep 26, 2023

I just prefer short function headers and don't want the redundancy, many of Flixel's functions are long enough to get autowrapped by the formatter and I try to avoid that. Note that when you mouse hover functions in VSCode it displays the type, regardless
Screenshot 2023-09-26 at 1 05 57 PM

@Geokureli Geokureli merged commit 0986c1e into HaxeFlixel:dev Sep 26, 2023
15 checks passed
@Geokureli
Copy link
Member

thanks!

Geokureli added a commit that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants