Fixes occasional crashes of Recurring Jobs page #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odinserj
reviewed
Nov 15, 2016
| @@ -100,7 +100,7 @@ | |||
| #if NETFULL | |||
| try | |||
| { | |||
| cronDescription = CronExpressionDescriptor.ExpressionDescriptor.GetDescription(job.Cron); | |||
| cronDescription = CronExpressionDescriptor.ExpressionDescriptor.GetDescription(job.Cron, new CronExpressionDescriptor.Options {ThrowExceptionOnParseError = false}); | |||
There was a problem hiding this comment.
Please add spaces within curly braces:
{ ThrowExceptionOnParseError = false }|
What CronExpressionDescriptor now returns in case of a null argument? |
… the value of Resharper setting 'Witin single-line initializer braces' as true
Current coverage is 67.34% (diff: 100%)
|
|
Now |
|
Thanks @aidmsu, 🚢 ping! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is problem with parsing of job cron expression Recurrig Jobs page will still be displayed.
This PR fixes #692