Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatpak: Update to GNOME 45 and fix Intel plugin #5455

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

robxnano
Copy link
Contributor

Updates the GUI Flatpak to GNOME 45 and the CLI to freedesktop 23.08, and adds a patch to fix the IntelMediaSDK. Also adds the rust-stable extension in order to build libdovi.

Tested on:

  • Windows 10+ (via MinGW)
  • macOS 10.13+
  • Ubuntu Linux

- fr.handbrake.ghb: Gnome 45
- fr.handbrake.HandBrakeCLI: FreeDesktop 23.08
- fr.handbrake.ghb.Plugin.IntelMediaSDK: Gnome 45
- Update Intel plugin libraries
- Add patch to fix Intel Media SDK build with GCC 13
Used when --enable-libdovi is passed to ./configure.
@sr55 sr55 added this to the 1.7.0 milestone Oct 15, 2023
@sr55 sr55 mentioned this pull request Oct 15, 2023
5 tasks
@sr55 sr55 self-assigned this Oct 18, 2023
@sr55
Copy link
Contributor

sr55 commented Oct 18, 2023

I'll try find some time at the weekend to get a test environment setup to validate this.

@sr55
Copy link
Contributor

sr55 commented Oct 22, 2023

Doesn't look like the QSV bundle wants to build. Getting packages for CLI and the GUI.

scott@Discovery:~/HandBrake/build$ make pkg.create.flatpak /usr/bin/mkdir -p /home/scott/HandBrake/build/stage/flatpak/ /usr/bin/mkdir -p /home/scott/HandBrake/build/pkg/flatpak/ ../scripts/create_flatpak_manifest.py -p -r development -t /home/scott/HandBrake/pkg/linux/flatpak/fr.handbrake.ghb.Plugin.IntelMediaSDK.json /home/scott/HandBrake/build/stage/flatpak/fr.handbrake.ghb.Plugin.IntelMediaSDK.json ARGS ['/home/scott/HandBrake/build/stage/flatpak/fr.handbrake.ghb.Plugin.IntelMediaSDK.json'] OPT [('-p', ''), ('-r', 'development'), ('-t', '/home/scott/HandBrake/pkg/linux/flatpak/fr.handbrake.ghb.Plugin.IntelMediaSDK.json')] flatpak --user remove --noninteractive fr.handbrake.ghb//development error: fr.handbrake.ghb/*unspecified*/development not installed make: [../pkg/linux/module.rules:96: /home/scott/HandBrake/build/pkg/flatpak/fr.handbrake.ghb.Plugin.IntelMediaSDK-20231018071745-43c78c3d5-master-x86_64.flatpak] Error 1 (ignored) flatpak --user install --noninteractive /home/scott/HandBrake/build/pkg/flatpak/fr.handbrake.ghb-20231018071745-43c78c3d5-master-x86_64.flatpak Installing app/fr.handbrake.ghb/x86_64/development Error: Failed to install bundle fr.handbrake.ghb: Could not connect: No such file or directory make: *** [../pkg/linux/module.rules:97: /home/scott/HandBrake/build/pkg/flatpak/fr.handbrake.ghb.Plugin.IntelMediaSDK-20231018071745-43c78c3d5-master-x86_64.flatpak] Error 1

@sr55
Copy link
Contributor

sr55 commented Oct 22, 2023

I'd also note we are getting intermittent failures to the numa-ctl git

Initialized empty Git repository in /home/scott/HandBrake/build/.flatpak-builder/git/https_github.com_numactl_numactl.git-G2MHD2/
fatal: unable to access 'https://github.com/numactl/numactl.git/': gnutls_handshake() failed: Error in the pull function.

Probably my end but maybe something we should switch to a package under our contribs git

@robxnano
Copy link
Contributor Author

@sr55 Could I ask what system you're running this on? The error message looks similar to this one caused by running Flatpak in Docker. Flatpak's security methods don't seem to interact well with other container systems.

@galad87
Copy link
Contributor

galad87 commented Oct 30, 2023

I was able to build the flatpak on a ubuntu 23 vm and run it. However I can't test the Intel plugin.

@sr55
Copy link
Contributor

sr55 commented Oct 30, 2023

It was Windows Subsystem for Linux. I have a laptop with Ubuntu on it but it'll be a week or so before I can do any further testing.

@galad87 galad87 merged commit ec8b8cd into HandBrake:master Nov 2, 2023
6 checks passed
@sr55
Copy link
Contributor

sr55 commented Nov 2, 2023

Seems my Ubuntu VM is fine with this.

Snapshot builds have been updated to include this: https://github.com/HandBrake/HandBrake-snapshots/releases/tag/lin

@robxnano robxnano deleted the flatpak branch January 3, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants