Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: QR Code images #257

Merged
merged 7 commits into from
May 22, 2024
Merged

feat: QR Code images #257

merged 7 commits into from
May 22, 2024

Conversation

db0
Copy link
Member

@db0 db0 commented May 19, 2024

  • Adds a QR workflow (AGPL) and hordelib scaffolding to support it.
  • Changes logging to intercept stdlib logging calls and rewrite them as loguru calls.

@db0 db0 marked this pull request as ready for review May 19, 2024 17:22
@tazlin tazlin changed the title Feat: QR Code images feat: QR Code images May 22, 2024
db0 and others added 7 commits May 22, 2024 10:27
- ComfyUI uses stdlib `logging` to emit messages now (instead of print).
- The original purpose of `OutputCollector` was to handle print specifically (and later, the TQDM messages for the purpose of emitting progress on inference so processes didn't appear stuck).
- However, now that ComfyUI (and other libraries always have) use `logging` we can intercept those messages and emit them through loguru. See `comfy_horde.py` for more info.
@tazlin tazlin merged commit 43dd792 into main May 22, 2024
1 of 2 checks passed
@tazlin tazlin deleted the qrcode branch May 22, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants