Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify both story and job can be return from list #19

Merged
merged 1 commit into from Jul 14, 2019

Conversation

louis993546
Copy link
Contributor

A small documentation update, to be clear that those "stories" endpoint may return item that is not type "story".

No. 78 is a job, not a story

(:point_up: no. 78 is a job, not a story. Taken on 2019/07/14)

Or is it possible for those endpoints to return any type of item? if that's the case, I think it'd still be nice to point it out.

@sctb
Copy link
Contributor

sctb commented Jul 14, 2019

Only topstories is going to return a job or a story; the others are just story. Do you want to update the PR to make that clear?

@louis993546
Copy link
Contributor Author

Updated accordingly.

@sctb sctb merged commit cc7184b into HackerNews:master Jul 14, 2019
@sctb
Copy link
Contributor

sctb commented Jul 14, 2019

Thanks! I've merged this so the full table is in our history if we want it, but for now I'd like to try a more lightweight change.

tngranados pushed a commit to tngranados/Hacker-News-API that referenced this pull request Jul 13, 2022
Specify both story and job can be return from list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants