Line semantics #1334
Merged
Line semantics #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b046c8
to
f02ebb2
Compare
schmidma
requested changes
Jul 19, 2024
1 task
62ac00b
to
71391d7
Compare
schmidma
approved these changes
Jul 31, 2024
oleflb
pushed a commit
to oleflb/hulk
that referenced
this pull request
Oct 7, 2024
* Define line as a point and direction vector * Add tests for line * Add comment explaining manual default implementation * Redefine Partial/Relative/AbsDiff equalities --------- Co-authored-by: Julian Schuler <[email protected]>
pejotejo
pushed a commit
to pejotejo/hulk
that referenced
this pull request
Nov 6, 2024
* Define line as a point and direction vector * Add tests for line * Add comment explaining manual default implementation * Redefine Partial/Relative/AbsDiff equalities --------- Co-authored-by: Julian Schuler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why? What?
This redefines a line as a point and a direction vector to further emphasize the difference to a line segment.
It additionally adds test cases for all functions defined for it.
ToDo / Known Issues
None.
Ideas for Next Iterations (Not This PR)
None.
How to Test
Build the code, run the tests.