Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/prebuild database files #97

Merged
merged 7 commits into from
Mar 18, 2021
Merged

Feature/prebuild database files #97

merged 7 commits into from
Mar 18, 2021

Conversation

martingraf4
Copy link
Collaborator

Closing #63

@martingraf4 martingraf4 added enhancement New feature or request app api labels Mar 18, 2021
@martingraf4 martingraf4 added this to the Extended Evaluation milestone Mar 18, 2021
@martingraf4 martingraf4 added this to In Progress in Snowman - Second Iteration via automation Mar 18, 2021
@martingraf4 martingraf4 linked an issue Mar 18, 2021 that may be closed by this pull request
New datasets from a new snowman version are not shown in the tool #63
Closed
@martingraf4
Copy link
Collaborator Author

@phpfs please review changes to app

Snowman - Second Iteration automation moved this from In Progress to Reviewer approved Mar 18, 2021
@phpfs
Copy link
Collaborator

phpfs commented Mar 18, 2021

What's up with the CI files? :D @martingraf4

phpfs
phpfs approved these changes Mar 18, 2021
View reviewed changes
Copy link
Collaborator

@phpfs phpfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend changes approved

@martingraf4
Copy link
Collaborator Author

What's up with the CI files? :D @martingraf4

A long running test in wrapper is only performed in CI environment (only via npm run test-ci, not npm run test. The many changes come from autoformat :D

@martingraf4 martingraf4 merged commit 22e921f into develop Mar 18, 2021
Snowman - Second Iteration automation moved this from Reviewer approved to Done Mar 18, 2021
@martingraf4 martingraf4 deleted the feature/prebuild-database-files branch March 18, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phpfs phpfs phpfs approved these changes

@Lasklu Lasklu Lasklu approved these changes

Assignees

@phpfs phpfs

@martingraf4 martingraf4

@Lasklu Lasklu

Labels
api app enhancement New feature or request
Projects
No open projects
Snowman - Second Iteration
Done
Milestone
Extended Evaluation
Development

Successfully merging this pull request may close these issues.

New datasets from a new snowman version are not shown in the tool
3 participants
@martingraf4 @phpfs @Lasklu