Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] GIF动图加载占用主线程 #2094

Closed
8MiYile opened this issue Feb 10, 2023 · 11 comments
Closed

[Bug] GIF动图加载占用主线程 #2094

8MiYile opened this issue Feb 10, 2023 · 11 comments

Comments

@8MiYile
Copy link

8MiYile commented Feb 10, 2023

启动器版本 Launcher Version

3.5.3.229

平台 Platform

Linux (Deepin)

问题描述 Problem Description

问题类型为启动器本身问题,已提交Log
顺带提交视频文件(复现步骤)
差不多等了20秒 这个动图才加载完毕,加载期间无法任何操作,也无额外界面提示等待
这也导致了在重新打开这个启动器的时候犹如在等Minecraft客户端加载出界面以及加载完毕到主页面一样

_org.jackhuang.hmcl.Launcher_20230210214911.mp4

Java

No response

游戏版本 Game Version

No response

对游戏所做的修改 Modifications Made to the Game

No response

游戏崩溃报告 Game Crash Report

No response

启动器崩溃报告 Launcher Crash Report

No response

启动器日志文件 Launcher Log File

https://mclo.gs/rcUahVB

@8MiYile 8MiYile added the bug label Feb 10, 2023
Glavo added a commit to Glavo/HMCL that referenced this issue Feb 10, 2023
@Glavo
Copy link
Member

Glavo commented Feb 10, 2023

@8MiYile
Copy link
Author

8MiYile commented Feb 11, 2023

@Glavo 修好其中一个了,还有另一个,启动器打开的时候也需要等20秒才能出界面

@Glavo
Copy link
Member

Glavo commented Feb 11, 2023

@Glavo 修好其中一个了,还有另一个,启动器打开的时候也需要等20秒才能出界面

设计中的行为,不然启动后背景是空的,过一会才能显示内容,对小一点的图片效果就成了启动后先闪一下空白背景,很难看。

@8MiYile
Copy link
Author

8MiYile commented Feb 11, 2023

@Glavo
额,我可能是没清楚我说的那个效果
在切换到加载GIF或者是启动器双击打开的时候,对于GIF文件大于1M的,可选用分段加载,1段60镇,1秒获取1段,这样就能从视觉方面改善加载问题
最起码先快速显示出GIF的第一帧吧

@8MiYile
Copy link
Author

8MiYile commented Feb 11, 2023

整个文件全部载入后再播放的这种操作,就感觉挺奇怪,对于GIF来说

@Glavo
Copy link
Member

Glavo commented Feb 11, 2023

@Glavo
额,我可能是没清楚我说的那个效果
在切换到加载GIF或者是启动器双击打开的时候,对于GIF文件大于1M的,可选用分段加载,1段60镇,1秒获取1段,这样就能从视觉方面改善加载问题
最起码先快速显示出GIF的第一帧吧

做不到,要魔改 JavaFX 内部,我不认为应该为了这种小众需求大费周折。

@8MiYile
Copy link
Author

8MiYile commented Feb 11, 2023

@Glavo 也就是说得看有多少人对于这部分有需求了
还有GIF动态加载的方式 JavaFX没有对应方法?
需要JavaFX开源仓库的地址,毕竟我想知道你们所用的JavaFX的提供方

@Glavo
Copy link
Member

Glavo commented Feb 11, 2023

没有办法,设计上就是一次性解码。

https://github.com/openjdk/jfx

@8MiYile
Copy link
Author

8MiYile commented Feb 11, 2023

草了 这东西是连issues都无的啊。。。

@Glavo
Copy link
Member

Glavo commented Feb 11, 2023

OpenJDK 项目的 Issue 在 Java Bug System 上,你可以通过 bugreport.java.com 提交问题。

@8MiYile
Copy link
Author

8MiYile commented Feb 12, 2023

有消息称HMCL背景图要支持WebP的静态和动态图,那我坐等那种格式的支持吧 GIF我就不管了

@8MiYile 8MiYile changed the title [Bug] GIF动图加载占用主线程 [Bug] GIF动图加载占用主线程 建议直接支持WebP且不要占用主线程 Feb 12, 2023
@Glavo Glavo changed the title [Bug] GIF动图加载占用主线程 建议直接支持WebP且不要占用主线程 [Bug] GIF动图加载占用主线程 Feb 12, 2023
@Glavo Glavo added enhancement and removed bug labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants