Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Technical corrections #235

Closed
wants to merge 5 commits into from
Closed

Conversation

pmechineniesac
Copy link
Contributor

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the acronyms changes that the tracker was asking: "8. Glossary. 13.2 Acronyms, Consider adding CRMI and SDC."

I think the tracker has a typo, it should be SDE instead of SDC. Add the following to the list of acronyms:;
SDE "Supplemental Data Element"
CRMI "Canonical Resource Management Infrastructure"

@yanheras
Copy link
Collaborator

Besides needing to add acronyms, all other changes look good.

@@ -70,7 +70,7 @@ Snippet 3-4 illustrates a FHIR Library resource containing a CQL library with a
**Conformance Requirement 3.1 (Referencing CQL Documents):** [<img src="conformance.png" width="20" class="self-link" height="20"/>](#conformance-requirement-3-1)
{: #conformance-requirement-3-1}

1. FHIR-based eCQMs SHALL consist of a FHIR Measure resource conforming to at least the CRMIShareableMeasure profile. In addition, measures with a status of active SHALL conform to the CQFMPublishableMeasure profile In particular, FHIR-based measures SHALL contain a narrative containing a human-readable representation of the measure content.
1. FHIR-based eCQMs SHALL consist of a FHIR Measure resource conforming to at least the CRMIShareableMeasure profile. In addition, measures with a status of active SHALL conform to the CQFMPublishableMeasure profile. In particular, FHIR-based measures SHALL contain a narrative containing a human-readable representation of the measure content.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change applied here conflicts with the changes applied to this same sentence in #247

Change "In addition, measures with a status of active SHALL
conform to the CQFMPublishableMeasure profile. In particular," to "In addition, measures with a status of active SHALL conform to the CQFMPublishableMeasure profile in particular." to be consistent with the changes applied in PR 247 for FHIR-45873.

Copy link
Collaborator

@yanheras yanheras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes still do not include adding the missing acronyms as requested by the tracker. Please see the prior PR review comments for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants