Detect pthread_setname_np with CMake #1587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
May 30, 2024
In some non-standard setups that slip through our checks, this function doesn't exist and we should guard against calling it. Since it's only used for debugging, let's just use CMake to check if it's defined in the header rather than complicated conditionals in the code for the 4 different possible versions of this that might exist.
Hoikas
approved these changes
May 30, 2024
zrax
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some non-standard setups that slip through our checks, this function doesn't exist and we should guard against calling it. Since it's only used for debugging, let's just use CMake to check if it's defined in the header rather than complicated conditionals in the code for all the different possible versions of this that might exist (or not exist).