Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Win7/8 resolution #1580

Merged
merged 3 commits into from
May 2, 2024
Merged

fix Win7/8 resolution #1580

merged 3 commits into from
May 2, 2024

Conversation

Filtik
Copy link
Contributor

@Filtik Filtik commented Apr 7, 2024

In Windows 7 and Windows 8 the intro is very small and no mouse cursor is visible.
This fixes the problem.

Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does appear to be correct. After fetching the DPI value, we do MulDiv(metricValue, dpiValue, 96), so I think the current (buggy) behaviour is dividing by 96 twice in some cases.

Sources/Plasma/PubUtilLib/plWinDpi/plWinDpi.cpp Outdated Show resolved Hide resolved
Sources/Plasma/PubUtilLib/plWinDpi/plWinDpi.cpp Outdated Show resolved Hide resolved
@Filtik Filtik requested a review from Hoikas April 8, 2024 19:50
@Hoikas
Copy link
Member

Hoikas commented Apr 18, 2024

When you have a chance, please rebase this onto master so that we can get a proper CI run.

@Hoikas Hoikas merged commit f865f41 into H-uru:master May 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants