Restore vftable of hsRefCount.
#1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores the vftable of `hsRefCount` to match its layout in TPotS and the original MOUL. Having these methods be virtual is extremely helpful in the case of ModDLLs that define external creatables. If you're making an external creatable, it's important that those creatables are allocated and deallocated by the ModDLL itself. If `UnRef()` is not virtual, then your external creatable may be deleted by the engine, which may not be built against the same C++ runtime library as the engine. If the two C++ runtime libraries are not ABI compatible, this can result in sinister crashes. This is most relevant for very, very old builds of the engine, such as TPotS (Visual C++ 6) where it would be nice to build a ModDLL with a newer compiler.
zrax
approved these changes
Jan 22, 2024
dpogue
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the vftable of
hsRefCountto match its layout in TPotS and the original MOUL. Having these methods be virtual is extremely helpful in the case of ModDLLs that define external creatables. If you're making an external creatable, it's important that those creatables are allocated and deallocated by the ModDLL itself. IfUnRef()is not virtual, then your external creatable may be deleted by the engine, which may not be built against the same C++ runtime library as the engine. If the two C++ runtime libraries are not ABI compatible, this can result in sinister crashes. This is most relevant for very, very old builds of the engine, such as TPotS (Visual C++ 6) where it would be nice to build a ModDLL with a newer compiler.(Yes, this does mean that I have made a ModDLL with an external creatable. The pure virtual function call was very surprising.)