Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle built-in samples #3

Closed
Gumichan01 opened this issue Mar 18, 2021 · 1 comment
Closed

Bundle built-in samples #3

Gumichan01 opened this issue Mar 18, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Gumichan01
Copy link
Owner

Gumichan01 commented Mar 18, 2021

From LMMS/lmms#1257 (comment)

built-in samples should be bundled because the future of LMMS is not guaranteed to contain the same exact built-in samples.

Difficulties:

  • Built-in samples are in LMMS/data/samples/
  • Some user samples are in LMMS_data/samples/

The path to LMMS samples is not known, so the user has to provide it manually.
I can reduce the burden by just letting the user provide the path to the LMMS directory (/path/to/lmms/) so I can get /path/to/lmms/data/samples and calculate /path/to/lmms_data/samples This soluton is platform dependent. The user has to provide information about where built-in samples are, because he/she must know where he/she installed the program.

This is not the best solution but it could do the job.

@Gumichan01 Gumichan01 added the enhancement New feature or request label Mar 18, 2021
@Gumichan01 Gumichan01 self-assigned this Mar 18, 2021
Gumichan01 added a commit that referenced this issue Mar 18, 2021
It is possible to specify several directories to extract built-in samples from.
@Gumichan01
Copy link
Owner Author

Including built-in samples must be done by providing the path to the samples directories in LMMS and LMMS data locations.

--lmms-dir "path/to/LMMS_Data/samples/" "path/to/LMMS/data/samples/"

You can specify multiples paths.

Commit 946800b fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant