Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle possible duplicated files #2

Closed
Gumichan01 opened this issue Mar 17, 2021 · 1 comment
Closed

Handle possible duplicated files #2

Gumichan01 opened this issue Mar 17, 2021 · 1 comment
Assignees
@Gumichan01
Labels
enhancement New feature or request

Comments

@Gumichan01
Copy link
Owner

From LMMS/lmms#1257 (comment)

Duplicate filename scenario:

Used samples:

a/kick.ogg
a/snare.ogg
b/kick.ogg
b/snare.ogg

Would become

samples/kick.ogg
samples/snare.ogg
samples/kick.1.ogg
samples/snare.1.ogg
`
@Gumichan01 Gumichan01 added the enhancement New feature or request label Mar 17, 2021
@Gumichan01 Gumichan01 self-assigned this Mar 17, 2021
Gumichan01 added a commit that referenced this issue Mar 20, 2021
@Gumichan01
Modify the return value of the multiple file copy
df9398a 
- The app handles an hash table with the source path as a key and the destination file name as the value
(instead of just the destination paths)
- Avoid file name collision in case several paths leads to different files with the same name.
- Replace some for_each function with a normal for loop

See Issue #2
Gumichan01 added a commit that referenced this issue Mar 20, 2021
@Gumichan01
Handle file name collision properly
2cf0fc7 
It is necessary to configure the exported package in order to take care of the file name
collision.

See issue #2
Gumichan01 added a commit that referenced this issue Mar 20, 2021
@Gumichan01
Fix the resource retrieval
efbd890 
Using find() instead of at(). It is safer.

Related to issue #2.
@Gumichan01
Copy link
Owner Author

Done. File name collision handled as expected. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gumichan01 Gumichan01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Gumichan01