Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for python 3.11, add gitignore, and improve README #94

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

bitofbreeze
Copy link

@bitofbreeze bitofbreeze commented Jun 22, 2024

This PR:

  • updates the dependencies rawpy and tensorflow to the minimum version that is compatible with Python 3.11.9
  • git-ignores the invisible file generated on macs, the virtualenv folder, and compiled Python files
  • makes the README table of contents links relative so they work in forks too

@GuidoBartoli
Copy link
Owner

Updates on README and git-ignores are fine, thank you for looking into that!

Unfortunately tensorflow 2.16 is incompatible with NoisePrint (it’s not my code, I just made it work inside Sherloq), so this change cannot be made at the moment.

I hope someday I can port the more powerful TruFor framework into Sherloq, because it uses PyTorch which is more retro-compatible than TensorFlow.

@bitofbreeze
Copy link
Author

bitofbreeze commented Jun 23, 2024

Thanks @GuidoBartoli Noise print seems to continue working for me:
image
Can you elaborate if I'm missing something? Maybe this will break if you retrain the model?

@GuidoBartoli GuidoBartoli merged commit f58d3e1 into GuidoBartoli:master Jun 24, 2024
@GuidoBartoli
Copy link
Owner

Ok, thanks for checking this, I also confirm that NoisePrint works with latest Tensorflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants