Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toggle to show keypoint coverage #21

Merged
merged 1 commit into from
Aug 8, 2020

Conversation

AlexRiina
Copy link
Contributor

Add a toggle to show the keypoints that the detector has identified for more easily debugging whether the an image contains copied sections.

I was looking into an image that has some copied subsections that were not detected by sherloq and noticed that at low contrast the image has very few keypoints detected. Bumping up the contrast helped the detectors find more points but it wasn't immediately obvious what was wrong because the detectors do still detect many keypoints.

My hard-coded color was not chosen thoughtfully, but could be set to the inverse of the center point.

peek-constrast
peek-original

@GuidoBartoli
Copy link
Owner

GuidoBartoli commented Aug 8, 2020

Thanks! 👍

Tomorrow I will be on holiday for 2 weeks, but when I will come back I will test and merge your addition and let you know.

EDIT: I saw the small change, I merged on trust before leaving 😉

@GuidoBartoli GuidoBartoli merged commit edcc5e6 into GuidoBartoli:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants